* [PATCH] staging: iio: adis16060: Fix coding style problem
@ 2014-08-06 17:06 Oussama Jabbari
2014-08-07 10:15 ` Jonathan Cameron
0 siblings, 1 reply; 2+ messages in thread
From: Oussama Jabbari @ 2014-08-06 17:06 UTC (permalink / raw)
To: jic23; +Cc: gregkh, sachin.kamat, lars, linux-iio, devel, linux-kernel
This patch fixes a warning from checkpatch.pl script :
"WARNING: Missing a blank line after declarations"
Signed-off-by: Oussama Jabbari <oussama.jabbari@gmail.com>
---
The reason of this patch is for completing one task
of the Eudyptula Challenge.
drivers/staging/iio/gyro/adis16060_core.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/iio/gyro/adis16060_core.c b/drivers/staging/iio/gyro/adis16060_core.c
index d5d395c..4c5869d 100644
--- a/drivers/staging/iio/gyro/adis16060_core.c
+++ b/drivers/staging/iio/gyro/adis16060_core.c
@@ -180,6 +180,7 @@ static int adis16060_w_probe(struct spi_device *spi)
int ret;
struct iio_dev *indio_dev = adis16060_iio_dev;
struct adis16060_state *st;
+
if (!indio_dev) {
ret = -ENODEV;
goto error_ret;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: iio: adis16060: Fix coding style problem
2014-08-06 17:06 [PATCH] staging: iio: adis16060: Fix coding style problem Oussama Jabbari
@ 2014-08-07 10:15 ` Jonathan Cameron
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2014-08-07 10:15 UTC (permalink / raw)
To: Oussama Jabbari
Cc: gregkh, sachin.kamat, lars, linux-iio, devel, linux-kernel
On 06/08/14 18:06, Oussama Jabbari wrote:
> This patch fixes a warning from checkpatch.pl script :
> "WARNING: Missing a blank line after declarations"
>
> Signed-off-by: Oussama Jabbari <oussama.jabbari@gmail.com>
Whilst I find it hard to care about this particular issue,
I'm accepting this mainly to avoid getting the same thing
sometime in the future!
Anyhow, a nicely formatted patch. The only change I would
have suggested would be in the title which might as be more
specific.
[PATCH] staging:iio:adis16060 Add missing blank line after declaration.
Applied to the togreg branch of iio.git - initially pushed out as
testing for the autobuilders to play with it.
J
> ---
> The reason of this patch is for completing one task
> of the Eudyptula Challenge.
>
> drivers/staging/iio/gyro/adis16060_core.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/iio/gyro/adis16060_core.c b/drivers/staging/iio/gyro/adis16060_core.c
> index d5d395c..4c5869d 100644
> --- a/drivers/staging/iio/gyro/adis16060_core.c
> +++ b/drivers/staging/iio/gyro/adis16060_core.c
> @@ -180,6 +180,7 @@ static int adis16060_w_probe(struct spi_device *spi)
> int ret;
> struct iio_dev *indio_dev = adis16060_iio_dev;
> struct adis16060_state *st;
> +
> if (!indio_dev) {
> ret = -ENODEV;
> goto error_ret;
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-08-07 10:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-08-06 17:06 [PATCH] staging: iio: adis16060: Fix coding style problem Oussama Jabbari
2014-08-07 10:15 ` Jonathan Cameron
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.