All of lore.kernel.org
 help / color / mirror / Atom feed
From: johan.hedberg@gmail.com
To: linux-bluetooth@vger.kernel.org
Subject: [PATCH 2/9] Bluetooth: Fix __l2cap_no_conn_pending() usage with all channels
Date: Thu,  7 Aug 2014 10:12:24 +0300	[thread overview]
Message-ID: <1407395551-30810-3-git-send-email-johan.hedberg@gmail.com> (raw)
In-Reply-To: <1407395551-30810-1-git-send-email-johan.hedberg@gmail.com>

From: Johan Hedberg <johan.hedberg@intel.com>

The __l2cap_no_conn_pending() function would previously only return a
meaningful value for connection oriented channels and was therefore not
useful for anything else. As preparation of making the L2CAP code more
generic allow the function to be called for other channel types as well
by returning a meaningful value for them.

Signed-off-by: Johan Hedberg <johan.hedberg@intel.com>
---
 net/bluetooth/l2cap_core.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/net/bluetooth/l2cap_core.c b/net/bluetooth/l2cap_core.c
index a49e9646a6b9..887f030beb5b 100644
--- a/net/bluetooth/l2cap_core.c
+++ b/net/bluetooth/l2cap_core.c
@@ -1082,6 +1082,9 @@ static void l2cap_send_rr_or_rnr(struct l2cap_chan *chan, bool poll)
 
 static inline int __l2cap_no_conn_pending(struct l2cap_chan *chan)
 {
+	if (chan->chan_type != L2CAP_CHAN_CONN_ORIENTED)
+		return true;
+
 	return !test_bit(CONF_CONNECT_PEND, &chan->conf_state);
 }
 
-- 
1.9.3


  parent reply	other threads:[~2014-08-07  7:12 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-07  7:12 [PATCH 0/9] Bluetooth: More generic L2CAP fixed channel handling johan.hedberg
2014-08-07  7:12 ` [PATCH 1/9] Bluetooth: Fix reference counting of global L2CAP channels johan.hedberg
2014-08-07 16:26   ` Marcel Holtmann
2014-08-07  7:12 ` johan.hedberg [this message]
2014-08-07  7:12 ` [PATCH 3/9] Bluetooth: Resume BT_CONNECTED state after LE security elevation johan.hedberg
2014-08-07  7:12 ` [PATCH 4/9] Bluetooth: Remove special handling of ATT in l2cap_security_cfm() johan.hedberg
2014-08-07  7:12 ` [PATCH 5/9] Bluetooth: Refactor l2cap_connect_cfm johan.hedberg
2014-08-07  7:12 ` [PATCH 6/9] Bluetooth: Move L2CAP fixed channel creation into l2cap_conn_cfm johan.hedberg
2014-08-07  7:12 ` [PATCH 7/9] Bluetooth: Improve fixed channel lookup based on link type johan.hedberg
2014-08-07  7:12 ` [PATCH 8/9] Bluetooth: Remove special ATT data channel handling johan.hedberg
2014-08-07  7:12 ` [PATCH 9/9] Bluetooth: Move parts of fixed channel initialization to l2cap_add_scid johan.hedberg
2014-08-08 17:43 ` [PATCH 0/9] Bluetooth: More generic L2CAP fixed channel handling Marcel Holtmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1407395551-30810-3-git-send-email-johan.hedberg@gmail.com \
    --to=johan.hedberg@gmail.com \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.