All of lore.kernel.org
 help / color / mirror / Atom feed
From: zhanghailiang <zhang.zhanghailiang@huawei.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, lkurusa@redhat.com,
	zhanghailiang <zhang.zhanghailiang@huawei.com>,
	mst@redhat.com, jan.kiszka@siemens.com, riku.voipio@iki.fi,
	mjt@tls.msk.ru, peter.huangpeng@huawei.com,
	lcapitulino@redhat.com, stefanha@redhat.com,
	luonengjun@huawei.com, pbonzini@redhat.com,
	alex.bennee@linaro.org, rth@twiddle.net
Subject: [Qemu-devel] [PATCH v4 03/10] virtio-blk: fix reference a pointer which might be freed
Date: Fri, 8 Aug 2014 17:21:05 +0800	[thread overview]
Message-ID: <1407489672-12212-4-git-send-email-zhang.zhanghailiang@huawei.com> (raw)
In-Reply-To: <1407489672-12212-1-git-send-email-zhang.zhanghailiang@huawei.com>

In function virtio_blk_handle_request, it may freed memory pointed by req,
So do not access member of req after calling this function.

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: zhanghailiang <zhang.zhanghailiang@huawei.com>
---
 hw/block/virtio-blk.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/hw/block/virtio-blk.c b/hw/block/virtio-blk.c
index c241c50..54a853a 100644
--- a/hw/block/virtio-blk.c
+++ b/hw/block/virtio-blk.c
@@ -458,7 +458,7 @@ static void virtio_blk_handle_output(VirtIODevice *vdev, VirtQueue *vq)
 static void virtio_blk_dma_restart_bh(void *opaque)
 {
     VirtIOBlock *s = opaque;
-    VirtIOBlockReq *req = s->rq;
+    VirtIOBlockReq *req = s->rq, *next = NULL;
     MultiReqBuffer mrb = {
         .num_writes = 0,
     };
@@ -469,8 +469,9 @@ static void virtio_blk_dma_restart_bh(void *opaque)
     s->rq = NULL;
 
     while (req) {
+        next = req->next;
         virtio_blk_handle_request(req, &mrb);
-        req = req->next;
+        req = next;
     }
 
     virtio_submit_multiwrite(s->bs, &mrb);
-- 
1.7.12.4

  parent reply	other threads:[~2014-08-08  9:23 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-08  9:21 [Qemu-devel] [PATCH v4 00/10] fix three bugs about use-after-free and several api abuse zhanghailiang
2014-08-08  9:21 ` [Qemu-devel] [PATCH v4 01/10] l2cap: fix access freed memory zhanghailiang
2014-08-08  9:21 ` [Qemu-devel] [PATCH v4 02/10] monitor: " zhanghailiang
2014-08-08  9:21 ` zhanghailiang [this message]
2014-08-08  9:21 ` [Qemu-devel] [PATCH v4 04/10] ivshmem: check the value returned by fstat() zhanghailiang
2014-08-08  9:21 ` [Qemu-devel] [PATCH v4 05/10] util/path: check return value of malloc() zhanghailiang
2014-08-08  9:36   ` Alex Bennée
2014-08-08 10:35     ` zhanghailiang
2014-08-08  9:21 ` [Qemu-devel] [PATCH v4 06/10] slirp/misc: " zhanghailiang
2014-08-08  9:43   ` Alex Bennée
2014-08-08 10:44     ` zhanghailiang
2014-08-08 13:24       ` Alex Bennée
2014-08-11  7:18         ` zhanghailiang
2014-08-08  9:21 ` [Qemu-devel] [PATCH v4 07/10] linux-user: " zhanghailiang
2014-08-08  9:21 ` [Qemu-devel] [PATCH v4 08/10] tests/bios-tables-test: check the value returned by fopen() zhanghailiang
2014-08-08  9:51   ` Alex Bennée
2014-08-08 10:46     ` zhanghailiang
2014-08-08  9:21 ` [Qemu-devel] [PATCH v4 09/10] tcg: check return value of fopen() zhanghailiang
2014-08-08  9:21 ` [Qemu-devel] [PATCH v4 10/10] block/vvfat: fix setbuf stream parameter may be NULL zhanghailiang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1407489672-12212-4-git-send-email-zhang.zhanghailiang@huawei.com \
    --to=zhang.zhanghailiang@huawei.com \
    --cc=alex.bennee@linaro.org \
    --cc=jan.kiszka@siemens.com \
    --cc=kwolf@redhat.com \
    --cc=lcapitulino@redhat.com \
    --cc=lkurusa@redhat.com \
    --cc=luonengjun@huawei.com \
    --cc=mjt@tls.msk.ru \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.huangpeng@huawei.com \
    --cc=qemu-devel@nongnu.org \
    --cc=riku.voipio@iki.fi \
    --cc=rth@twiddle.net \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.