All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ronnie Sahlberg <sahlberg@google.com>
To: git@vger.kernel.org
Cc: Ronnie Sahlberg <sahlberg@google.com>
Subject: [PATCH 11/22] refs-common.c: move resolve_refdup to common
Date: Fri,  8 Aug 2014 09:44:58 -0700	[thread overview]
Message-ID: <1407516309-27989-12-git-send-email-sahlberg@google.com> (raw)
In-Reply-To: <1407516309-27989-1-git-send-email-sahlberg@google.com>

This function can be shared across all refs backends so move it
to the common code.

Signed-off-by: Ronnie Sahlberg <sahlberg@google.com>
---
 refs-common.c | 6 ++++++
 refs.c        | 6 ------
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/refs-common.c b/refs-common.c
index 37d3d14..655a1a0 100644
--- a/refs-common.c
+++ b/refs-common.c
@@ -565,3 +565,9 @@ int ref_exists(const char *refname)
 	unsigned char sha1[20];
 	return !!resolve_ref_unsafe(refname, sha1, RESOLVE_REF_READING, NULL);
 }
+
+char *resolve_refdup(const char *ref, unsigned char *sha1, int flags, int *ref_flag)
+{
+	const char *ret = resolve_ref_unsafe(ref, sha1, flags, ref_flag);
+	return ret ? xstrdup(ret) : NULL;
+}
diff --git a/refs.c b/refs.c
index a94378e..ed7bc61 100644
--- a/refs.c
+++ b/refs.c
@@ -1501,12 +1501,6 @@ const char *resolve_ref_unsafe(const char *refname, unsigned char *sha1, int fla
 	}
 }
 
-char *resolve_refdup(const char *ref, unsigned char *sha1, int flags, int *ref_flag)
-{
-	const char *ret = resolve_ref_unsafe(ref, sha1, flags, ref_flag);
-	return ret ? xstrdup(ret) : NULL;
-}
-
 /* The argument to filter_refs */
 struct ref_filter {
 	const char *pattern;
-- 
2.0.1.553.geee1b3e

  parent reply	other threads:[~2014-08-08 16:45 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-08 16:44 [PATCH 00/22] backend-struct-db Ronnie Sahlberg
2014-08-08 16:44 ` [PATCH 01/22] refs.c: create a public function for is_refname_available Ronnie Sahlberg
2014-08-08 17:27   ` David Turner
2014-08-11 15:00     ` Ronnie Sahlberg
2014-08-08 16:44 ` [PATCH 02/22] refs-common.c: create a file to host all common refs code Ronnie Sahlberg
2014-08-08 16:44 ` [PATCH 03/22] refs-common.c: move update_ref to refs-common.c Ronnie Sahlberg
2014-08-08 16:44 ` [PATCH 04/22] refs-common.c: move delete_ref to the common code Ronnie Sahlberg
2014-08-08 16:44 ` [PATCH 05/22] refs-common.c: move rename_ref " Ronnie Sahlberg
2014-08-08 16:44 ` [PATCH 06/22] refs-common.c: move read_ref_at to the refs common file Ronnie Sahlberg
2014-08-08 16:44 ` [PATCH 07/22] refs-common.c: move the hidden refs functions to the common code Ronnie Sahlberg
2014-08-08 16:44 ` [PATCH 08/22] refs-common.c: move dwim and friend functions to refs common Ronnie Sahlberg
2014-08-08 16:44 ` [PATCH 09/22] refs-common.c: move warn_if_dangling_symref* to refs-common Ronnie Sahlberg
2014-08-08 16:44 ` [PATCH 10/22] refs-common.c: move read_ref, read_ref_full and ref_exists to common Ronnie Sahlberg
2014-08-08 16:44 ` Ronnie Sahlberg [this message]
2014-08-08 16:44 ` [PATCH 12/22] refs-common.c: move check_refname_component to the common code Ronnie Sahlberg
2014-08-08 16:45 ` [PATCH 13/22] refs-common.c: move is_branch " Ronnie Sahlberg
2014-08-08 16:45 ` [PATCH 14/22] refs-common.c: move names_conflict " Ronnie Sahlberg
2014-08-08 16:45 ` [PATCH 15/22] refs-common.c: move prettify_refname " Ronnie Sahlberg
2014-08-08 16:45 ` [PATCH 16/22] refs-common.c: move ref iterators " Ronnie Sahlberg
2014-08-08 16:45 ` [PATCH 17/22] refs.c: add a backend method structure with transaction functions Ronnie Sahlberg
2014-08-08 18:17   ` David Turner
2014-08-11 14:56     ` Ronnie Sahlberg
2014-08-08 16:45 ` [PATCH 18/22] refs.c: add reflog backend methods Ronnie Sahlberg
2014-08-08 16:45 ` [PATCH 19/22] refs.c: add methods for misc ref operations Ronnie Sahlberg
2014-08-08 16:45 ` [PATCH 20/22] refs.c: add methods for head_ref* Ronnie Sahlberg
2014-08-08 16:45 ` [PATCH 21/22] refs.c: add methods for the ref iterators Ronnie Sahlberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1407516309-27989-12-git-send-email-sahlberg@google.com \
    --to=sahlberg@google.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.