From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: =?UTF-8?B?QWxleGFuZGVyIFNoaXlhbg==?= Subject: =?UTF-8?B?UmU6IFtQQVRDSCA0LzRdIEFSTTogZHRzOiBrZXlzdG9uZS1rMmhrOiBhZGQg?= =?UTF-8?B?ZHNwIGdwaW8gY29udHJvbGxlcnMgbm9kZXM=?= Mime-Version: 1.0 Date: Wed, 13 Aug 2014 20:06:24 +0400 Message-ID: <1407945984.545232249@f170.i.mail.ru> In-Reply-To: <1407946582-20927-5-git-send-email-grygorii.strashko@ti.com> References: <1407946582-20927-1-git-send-email-grygorii.strashko@ti.com> <1407946582-20927-5-git-send-email-grygorii.strashko@ti.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: =?UTF-8?B?QWxleGFuZGVyIFNoaXlhbg==?= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+robherring2=gmail.com@lists.infradead.org To: =?UTF-8?B?R3J5Z29yaWkgU3RyYXNoa28=?= Cc: =?UTF-8?B?QWxleGFuZHJlIENvdXJib3Q=?= , devicetree@vger.kernel.org, =?UTF-8?B?TGludXMgV2FsbGVpag==?= , linux-gpio@vger.kernel.org, =?UTF-8?B?Um9iIEhlcnJpbmc=?= , santosh.shilimkar@ti.com, linux-arm-kernel@lists.infradead.org List-ID: V2VkLCAxMyBBdWcgMjAxNCAxOToxNjoyMiArMDMwMCDQvtGCIEdyeWdvcmlpIFN0cmFzaGtvIDxn cnlnb3JpaS5zdHJhc2hrb0B0aS5jb20+Ogo+IEFkZCBLZXlzdG9uZSAyIERTUCBHUElPIG5vZGVz Lgo+IERTUCBHUElPIGJhbmtzIDAtNyBjb3JyZXNwb25kIHRvIERTUDAtRFNQNwo+IAo+IFNpZ25l ZC1vZmYtYnk6IEdyeWdvcmlpIFN0cmFzaGtvIDxncnlnb3JpaS5zdHJhc2hrb0B0aS5jb20+Cj4g LS0tCj4gIGFyY2gvYXJtL2Jvb3QvZHRzL2syaGsuZHRzaSB8ICAgNTYgKysrKysrKysrKysrKysr KysrKysrKysrKysrKysrKysrKysrKysrKysrKwo+ICAxIGZpbGUgY2hhbmdlZCwgNTYgaW5zZXJ0 aW9ucygrKQo+IAo+IGRpZmYgLS1naXQgYS9hcmNoL2FybS9ib290L2R0cy9rMmhrLmR0c2kgYi9h cmNoL2FybS9ib290L2R0cy9rMmhrLmR0c2kKPiBpbmRleCAzMjFiYTJmLi4wMDllMTgwIDEwMDY0 NAo+IC0tLSBhL2FyY2gvYXJtL2Jvb3QvZHRzL2syaGsuZHRzaQo+ICsrKyBiL2FyY2gvYXJtL2Jv b3QvZHRzL2syaGsuZHRzaQo+IEBAIC01MCw1ICs1MCw2MSBAQAo+ICAJCQkjaW50ZXJydXB0LWNl bGxzID0gPDE+Owo+ICAJCQl0aSxzeXNjb24tZGV2ID0gPCZkZXZjdHJsIDB4MmEwPjsKPiAgCQl9 Owo+ICsKPiArCQlkc3BncGlvMDoga2V5c3RvbmVfZHNwX2dwaW9AMDI2MjAyNDAgewo+ICsJCQlj b21wYXRpYmxlID0gInRpLGtleXN0b25lLW1jdHJsLWdwaW8iOwo+ICsJCQlncGlvLWNvbnRyb2xs ZXI7Cj4gKwkJCSNncGlvLWNlbGxzID0gPDI+Owo+ICsJCQlncGlvLHN5c2Nvbi1kZXYgPSA8JmRl dmN0cmwgMHgyNDA+Owo+ICsJCX07Cj4gKwo+ICsJCWRzcGdwaW8xOiBrZXlzdG9uZV9kc3BfZ3Bp b0AyNjIwMjQ0IHsKPiArCQkJY29tcGF0aWJsZSA9ICJ0aSxrZXlzdG9uZS1tY3RybC1ncGlvIjsK PiArCQkJZ3Bpby1jb250cm9sbGVyOwo+ICsJCQkjZ3Bpby1jZWxscyA9IDwyPjsKPiArCQkJZ3Bp byxzeXNjb24tZGV2ID0gPCZkZXZjdHJsIDB4MjQ0PjsKPiArCQl9OwouLi4KPiArCQlkc3BncGlv Nzoga2V5c3RvbmVfZHNwX2dwaW9AMjYyMDI1QyB7Cj4gKwkJCWNvbXBhdGlibGUgPSAidGksa2V5 c3RvbmUtbWN0cmwtZ3BpbyI7Cj4gKwkJCWdwaW8tY29udHJvbGxlcjsKPiArCQkJI2dwaW8tY2Vs bHMgPSA8Mj47Cj4gKwkJCWdwaW8sc3lzY29uLWRldiA9IDwmZGV2Y3RybCAweDI1Yz47Cj4gKwkJ fTsKClNvLCBkZXZjdHJsIGlzIGEgc3lzY29uIGRldmljZSBhbmQgdGhpcyBEVFMgaW50cm9kdWNl IHNldmVyYWwKaWRlbnRpY2FsIEdQSU8gZGVzY3JpcHRpb25zPwoKT24gbXkgb3BpbmlvbiB0aGlz IHNob3VsZCBiZSBwbGFjZWQgaW4gdGhlIGdwaW8tc3lzY29uLmMsCndoZXJlIHlvdSBjYW4gYWRk IHN1cHBvcnQgZm9yIHRpLGtleXN0b25lLWRzcDB7Li43fS1ncGlvLgpTdWNoIGNoYW5nZSB3aWxs IGF2b2lkIHBhcnRzIDIgYW5kIDMgb2YgdGhpcyBwYXRjaC4KCnN0YXRpYyBjb25zdCBzdHJ1Y3Qg c3lzY29uX2dwaW9fZGF0YSB0aV9rZXlzdG9uZV9kc3AwX2dwaW8gPSB7CiAgLmNvbXBhdGlibGUg PSAidGksa2V5c3RvbmUtc3lzY29uIiwKICAuZGF0X2JpdF9vZmZzZXQgPSAweDI0MCAqIDgsCiAg Li4uCiAgLnNldCA9IGV0Yy4uLgp9OwoKLS0tCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1h cm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcv bWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: shc_work@mail.ru (=?UTF-8?B?QWxleGFuZGVyIFNoaXlhbg==?=) Date: Wed, 13 Aug 2014 20:06:24 +0400 Subject: =?UTF-8?B?UmU6IFtQQVRDSCA0LzRdIEFSTTogZHRzOiBrZXlzdG9uZS1rMmhrOiBhZGQg?= =?UTF-8?B?ZHNwIGdwaW8gY29udHJvbGxlcnMgbm9kZXM=?= In-Reply-To: <1407946582-20927-5-git-send-email-grygorii.strashko@ti.com> References: <1407946582-20927-1-git-send-email-grygorii.strashko@ti.com> <1407946582-20927-5-git-send-email-grygorii.strashko@ti.com> Message-ID: <1407945984.545232249@f170.i.mail.ru> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Wed, 13 Aug 2014 19:16:22 +0300 ?? Grygorii Strashko : > Add Keystone 2 DSP GPIO nodes. > DSP GPIO banks 0-7 correspond to DSP0-DSP7 > > Signed-off-by: Grygorii Strashko > --- > arch/arm/boot/dts/k2hk.dtsi | 56 +++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 56 insertions(+) > > diff --git a/arch/arm/boot/dts/k2hk.dtsi b/arch/arm/boot/dts/k2hk.dtsi > index 321ba2f..009e180 100644 > --- a/arch/arm/boot/dts/k2hk.dtsi > +++ b/arch/arm/boot/dts/k2hk.dtsi > @@ -50,5 +50,61 @@ > #interrupt-cells = <1>; > ti,syscon-dev = <&devctrl 0x2a0>; > }; > + > + dspgpio0: keystone_dsp_gpio at 02620240 { > + compatible = "ti,keystone-mctrl-gpio"; > + gpio-controller; > + #gpio-cells = <2>; > + gpio,syscon-dev = <&devctrl 0x240>; > + }; > + > + dspgpio1: keystone_dsp_gpio at 2620244 { > + compatible = "ti,keystone-mctrl-gpio"; > + gpio-controller; > + #gpio-cells = <2>; > + gpio,syscon-dev = <&devctrl 0x244>; > + }; ... > + dspgpio7: keystone_dsp_gpio at 262025C { > + compatible = "ti,keystone-mctrl-gpio"; > + gpio-controller; > + #gpio-cells = <2>; > + gpio,syscon-dev = <&devctrl 0x25c>; > + }; So, devctrl is a syscon device and this DTS introduce several identical GPIO descriptions? On my opinion this should be placed in the gpio-syscon.c, where you can add support for ti,keystone-dsp0{..7}-gpio. Such change will avoid parts 2 and 3 of this patch. static const struct syscon_gpio_data ti_keystone_dsp0_gpio = { .compatible = "ti,keystone-syscon", .dat_bit_offset = 0x240 * 8, ... .set = etc... }; ---