From: Fam Zheng <famz@redhat.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, pbonzini@redhat.com, mjt@tls.msk.ru,
stefanha@redhat.com
Subject: [Qemu-devel] [PATCH 0/6] build-sys: Fix iscsi module loading failure
Date: Wed, 20 Aug 2014 18:01:21 +0800 [thread overview]
Message-ID: <1408528887-22200-1-git-send-email-famz@redhat.com> (raw)
The iscsi driver doesn't work if built with --enable-modules:
$ ~/build/last/qemu-img
Failed to open module: /home/fam/build/master/block-iscsi.so: undefined symbol: qmp_query_uuid
qemu-img: Not enough arguments
Try 'qemu-img --help' for more information
This fixes it by completely linking libqemuutil.a (now qemuutil.o) rather than
on demand.
A few stub functions are added into libqemustub to make linker happy.
Lastly, iqn generation code is moved from iscsi.c to util, so that
qmp_query_uuid or its stub is not missed.
Fam
Fam Zheng (6):
build-sys: Move fifio8 to hw/
stubs: Add iohandler.c
stubs: Add openpty.c
stubs: Add timer.c
build-sys: Change libqemuutil.a to qemuutil.o and link whole object
iscsi: Move iqn generation code to util
Makefile | 17 ++++---
Makefile.objs | 2 +-
Makefile.target | 2 +-
block/iscsi.c | 15 +-----
hw/Makefile.objs | 1 +
hw/fifo8.c | 125 ++++++++++++++++++++++++++++++++++++++++++++++++++
include/qemu-common.h | 3 ++
stubs/Makefile.objs | 3 ++
stubs/iohandler.c | 20 ++++++++
stubs/openpty.c | 21 +++++++++
stubs/timer.c | 44 ++++++++++++++++++
tests/Makefile | 60 ++++++++++++------------
util/Makefile.objs | 2 +-
util/fifo8.c | 125 --------------------------------------------------
util/iqn.c | 38 +++++++++++++++
15 files changed, 299 insertions(+), 179 deletions(-)
create mode 100644 hw/fifo8.c
create mode 100644 stubs/iohandler.c
create mode 100644 stubs/openpty.c
create mode 100644 stubs/timer.c
delete mode 100644 util/fifo8.c
create mode 100644 util/iqn.c
--
2.0.3
next reply other threads:[~2014-08-20 10:48 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-20 10:01 Fam Zheng [this message]
2014-08-20 10:01 ` [Qemu-devel] [PATCH 1/6] build-sys: Move fifio8 to hw/ Fam Zheng
2014-08-20 13:33 ` Paolo Bonzini
2014-08-20 14:23 ` Peter Crosthwaite
2014-08-20 14:52 ` Fam Zheng
2014-08-20 10:01 ` [Qemu-devel] [PATCH 2/6] stubs: Add iohandler.c Fam Zheng
2014-08-20 13:25 ` Paolo Bonzini
2014-08-20 10:01 ` [Qemu-devel] [PATCH 3/6] stubs: Add openpty.c Fam Zheng
2014-08-20 13:26 ` Paolo Bonzini
2014-08-20 10:01 ` [Qemu-devel] [PATCH 4/6] stubs: Add timer.c Fam Zheng
2014-08-20 13:27 ` Paolo Bonzini
2014-08-20 10:01 ` [Qemu-devel] [PATCH 5/6] build-sys: Change libqemuutil.a to qemuutil.o and link whole object Fam Zheng
2014-08-20 13:29 ` Paolo Bonzini
2014-08-21 3:02 ` Fam Zheng
2014-08-21 9:04 ` Paolo Bonzini
2014-08-20 10:01 ` [Qemu-devel] [PATCH 6/6] iscsi: Move iqn generation code to util Fam Zheng
2014-08-20 13:32 ` Paolo Bonzini
2014-08-20 15:03 ` Fam Zheng
2014-08-21 3:54 ` Fam Zheng
2014-08-21 9:02 ` Paolo Bonzini
2014-08-21 9:12 ` Fam Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1408528887-22200-1-git-send-email-famz@redhat.com \
--to=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=mjt@tls.msk.ru \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.