From: Javier Martinez Canillas <javier.martinez@collabora.co.uk> To: Lee Jones <lee.jones@linaro.org> Cc: "Wolfram Sang" <wsa@the-dreams.de>, "Dmitry Torokhov" <dmitry.torokhov@gmail.com>, "Doug Anderson" <dianders@chromium.org>, "Simon Glass" <sjg@chromium.org>, "Bill Richardson" <wfrichar@chromium.org>, "Andrew Bresticker" <abrestic@chromium.org>, "Derek Basehore" <dbasehore@chromium.org>, "Todd Broch" <tbroch@chromium.org>, "Olof Johansson" <olof@lixom.net>, "Andreas Färber" <afaerber@suse.de>, linux-i2c@vger.kernel.org, linux-input@vger.kernel.org, linux-samsung-soc@vger.kernel.org, "Javier Martinez Canillas" <javier.martinez@collabora.co.uk> Subject: [RESEND PATCH 5/7] mfd: cros_ec: wait for completion of commands that return IN_PROGRESS Date: Wed, 20 Aug 2014 14:13:30 +0200 [thread overview] Message-ID: <1408536812-7836-6-git-send-email-javier.martinez@collabora.co.uk> (raw) In-Reply-To: <1408536812-7836-1-git-send-email-javier.martinez@collabora.co.uk> From: Andrew Bresticker <abrestic@chromium.org> When an EC command returns EC_RES_IN_PROGRESS, we need to query the state of the EC until it indicates that it is no longer busy. Do this in cros_ec_cmd_xfer() under the EC's mutex so that other commands (e.g. keyboard, I2C passtru) aren't issued to the EC while it is working on the in-progress command. Signed-off-by: Andrew Bresticker <abrestic@chromium.org> Reviewed-by: Simon Glass <sjg@chromium.org> Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk> --- drivers/mfd/cros_ec.c | 35 ++++++++++++++++++++++++++++++++++- 1 file changed, 34 insertions(+), 1 deletion(-) diff --git a/drivers/mfd/cros_ec.c b/drivers/mfd/cros_ec.c index c53804a..634c434 100644 --- a/drivers/mfd/cros_ec.c +++ b/drivers/mfd/cros_ec.c @@ -23,6 +23,10 @@ #include <linux/mfd/core.h> #include <linux/mfd/cros_ec.h> #include <linux/mfd/cros_ec_commands.h> +#include <linux/delay.h> + +#define EC_COMMAND_RETRIES 50 +#define EC_RETRY_DELAY_MS 10 int cros_ec_prepare_tx(struct cros_ec_device *ec_dev, struct cros_ec_command *msg) @@ -65,10 +69,39 @@ EXPORT_SYMBOL(cros_ec_check_result); int cros_ec_cmd_xfer(struct cros_ec_device *ec_dev, struct cros_ec_command *msg) { - int ret; + int ret, i; mutex_lock(&ec_dev->lock); ret = ec_dev->cmd_xfer(ec_dev, msg); + if (ret == -EAGAIN && msg->result == EC_RES_IN_PROGRESS) { + /* + * Query the EC's status until it's no longer busy or + * we encounter an error. + */ + for (i = 0; i < EC_COMMAND_RETRIES; i++) { + struct cros_ec_command status_msg; + struct ec_response_get_comms_status status; + + msleep(EC_RETRY_DELAY_MS); + + status_msg.version = 0; + status_msg.command = EC_CMD_GET_COMMS_STATUS; + status_msg.outdata = NULL; + status_msg.outsize = 0; + status_msg.indata = (uint8_t *)&status; + status_msg.insize = sizeof(status); + + ret = ec_dev->cmd_xfer(ec_dev, &status_msg); + if (ret < 0) + break; + + msg->result = status_msg.result; + if (status_msg.result != EC_RES_SUCCESS) + break; + if (!(status.flags & EC_COMMS_STATUS_PROCESSING)) + break; + } + } mutex_unlock(&ec_dev->lock); return ret; -- 2.0.1
next prev parent reply other threads:[~2014-08-20 12:13 UTC|newest] Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-08-20 12:13 [RESEND PATCH 0/7] Second batch of cleanups for cros_ec Javier Martinez Canillas 2014-08-20 12:13 ` [RESEND PATCH 1/7] mfd: cros_ec: Delay for 50ms when we see EC_CMD_REBOOT_EC Javier Martinez Canillas 2014-08-21 13:37 ` Lee Jones 2014-08-21 13:49 ` Javier Martinez Canillas [not found] ` <1408536812-7836-1-git-send-email-javier.martinez-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org> 2014-08-20 12:13 ` [RESEND PATCH 2/7] i2c: i2c-cros-ec-tunnel: Set retries to 3 Javier Martinez Canillas 2014-08-20 12:13 ` [RESEND PATCH 3/7] mfd: cros_ec: stop calling ->cmd_xfer() directly Javier Martinez Canillas 2014-08-20 22:33 ` Doug Anderson 2014-08-21 14:08 ` Lee Jones 2014-08-20 12:13 ` [RESEND PATCH 6/7] mfd: cros_ec: Instantiate sub-devices from device tree Javier Martinez Canillas [not found] ` <1408536812-7836-7-git-send-email-javier.martinez-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org> 2014-08-21 14:25 ` Lee Jones 2014-08-22 11:27 ` Javier Martinez Canillas 2014-08-20 12:13 ` [RESEND PATCH 7/7] Input: cros_ec_keyb: Optimize ghosting algorithm Javier Martinez Canillas 2014-08-20 12:13 ` [RESEND PATCH 4/7] mfd: cros_ec: move locking into cros_ec_cmd_xfer Javier Martinez Canillas 2014-08-20 22:36 ` Doug Anderson 2014-08-21 10:24 ` Javier Martinez Canillas 2014-08-21 14:09 ` Lee Jones 2014-08-20 12:13 ` Javier Martinez Canillas [this message] [not found] ` <1408536812-7836-6-git-send-email-javier.martinez-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org> 2014-08-21 14:21 ` [RESEND PATCH 5/7] mfd: cros_ec: wait for completion of commands that return IN_PROGRESS Lee Jones 2014-08-22 11:24 ` Javier Martinez Canillas
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1408536812-7836-6-git-send-email-javier.martinez@collabora.co.uk \ --to=javier.martinez@collabora.co.uk \ --cc=abrestic@chromium.org \ --cc=afaerber@suse.de \ --cc=dbasehore@chromium.org \ --cc=dianders@chromium.org \ --cc=dmitry.torokhov@gmail.com \ --cc=lee.jones@linaro.org \ --cc=linux-i2c@vger.kernel.org \ --cc=linux-input@vger.kernel.org \ --cc=linux-samsung-soc@vger.kernel.org \ --cc=olof@lixom.net \ --cc=sjg@chromium.org \ --cc=tbroch@chromium.org \ --cc=wfrichar@chromium.org \ --cc=wsa@the-dreams.de \ --subject='Re: [RESEND PATCH 5/7] mfd: cros_ec: wait for completion of commands that return IN_PROGRESS' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.