From: Gui Hecheng <guihc.fnst@cn.fujitsu.com>
To: Marc Dietrich <marvin24@gmx.de>
Cc: <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH] btrfs-progs: init uninitialized output buf for btrfs-restore
Date: Thu, 21 Aug 2014 17:43:00 +0800 [thread overview]
Message-ID: <1408614180.11298.0.camel@localhost.localdomain> (raw)
In-Reply-To: <2179924.d4q2ELedVV@fb07-iapwap2>
On Thu, 2014-08-21 at 10:14 +0200, Marc Dietrich wrote:
> Hi Gui,
>
> Am Donnerstag, 21. August 2014, 11:35:36 schrieb Gui Hecheng:
> > A memory problem reported by valgrind as follows:
> > === Syscall param pwrite64(buf) points to uninitialised byte(s)
> > When running:
> > # valgrind --leak-check=yes btrfs restore /dev/sda9 /mnt/backup
> >
> > Because the output buf size is alloced with malloc, but the length of
> > output data is shorter than the sizeof(buf), so valgrind report
> > uninitialised byte(s).
> > We could use calloc to repalce malloc and clear this WARNING away.
>
> yes, the warning vanished. But the reads from free'd memory make me more
> worring...
Ah, yeah, I am looking into it, hope that I can do some help :)
> Marc
next prev parent reply other threads:[~2014-08-21 9:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-21 3:35 [PATCH] btrfs-progs: init uninitialized output buf for btrfs-restore Gui Hecheng
2014-08-21 8:14 ` Marc Dietrich
2014-08-21 9:43 ` Gui Hecheng [this message]
2014-08-21 18:42 ` Eric Sandeen
2014-08-21 18:56 ` Eric Sandeen
2014-08-22 7:35 ` Marc Dietrich
2014-08-22 15:19 ` Eric Sandeen
2014-08-22 15:29 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1408614180.11298.0.camel@localhost.localdomain \
--to=guihc.fnst@cn.fujitsu.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=marvin24@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.