All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daeseok Youn <daeseok.youn@gmail.com>
To: m.chehab@samsung.com
Cc: linux-dev@sensoray.com, hans.verkuil@cisco.com,
	sakari.ailus@iki.fi, linux-media@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH] [media] s2255drv: fix memory leak s2255_probe()
Date: Tue, 15 Apr 2014 13:49:34 +0900	[thread overview]
Message-ID: <1408657.25U3i1DfG3@daeseok-laptop.cloud.net> (raw)


smatch says:
 drivers/media/usb/s2255/s2255drv.c:2246 s2255_probe() warn:
possible memory leak of 'dev'

Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
---
 drivers/media/usb/s2255/s2255drv.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/media/usb/s2255/s2255drv.c b/drivers/media/usb/s2255/s2255drv.c
index 1d4ba2b..8aca3ef 100644
--- a/drivers/media/usb/s2255/s2255drv.c
+++ b/drivers/media/usb/s2255/s2255drv.c
@@ -2243,6 +2243,7 @@ static int s2255_probe(struct usb_interface *interface,
 	dev->cmdbuf = kzalloc(S2255_CMDBUF_SIZE, GFP_KERNEL);
 	if (dev->cmdbuf == NULL) {
 		s2255_dev_err(&interface->dev, "out of memory\n");
+		kfree(dev);
 		return -ENOMEM;
 	}
 
-- 
1.7.4.4



             reply	other threads:[~2014-04-15  4:49 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-15  4:49 Daeseok Youn [this message]
2014-04-15  9:33 ` [PATCH] [media] s2255drv: fix memory leak s2255_probe() Sakari Ailus
2014-04-15 10:54   ` DaeSeok Youn
2014-05-05  8:38     ` Sakari Ailus
2014-05-07  4:38       ` DaeSeok Youn
2014-05-08 11:21         ` Sakari Ailus
2014-05-08 22:57 Daeseok Youn
2014-05-09  7:32 ` Sakari Ailus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1408657.25U3i1DfG3@daeseok-laptop.cloud.net \
    --to=daeseok.youn@gmail.com \
    --cc=hans.verkuil@cisco.com \
    --cc=linux-dev@sensoray.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=m.chehab@samsung.com \
    --cc=sakari.ailus@iki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.