From: Vlastimil Babka <vbabka@suse.cz>
To: Minchan Kim <minchan@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
linux-mm <linux-mm@kvack.org>,
linux-api@vger.kernel.org, oleksandr@redhat.com,
Suren Baghdasaryan <surenb@google.com>,
Tim Murray <timmurray@google.com>,
Daniel Colascione <dancol@google.com>,
Sandeep Patil <sspatil@google.com>,
Sonny Rao <sonnyrao@google.com>,
Brian Geffon <bgeffon@google.com>, Michal Hocko <mhocko@suse.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Shakeel Butt <shakeelb@google.com>,
John Dias <joaodias@google.com>,
Joel Fernandes <joel@joelfernandes.org>,
Jann Horn <jannh@google.com>,
alexander.h.duyck@linux.intel.com, sj38.park@gmail.com,
Christian Brauner <christian@brauner.io>,
Kirill Tkhai <ktkhai@virtuozzo.com>
Subject: Re: [PATCH v7 5/7] mm: support both pid and pidfd for process_madvise
Date: Fri, 6 Mar 2020 12:14:19 +0100 [thread overview]
Message-ID: <14089609-5fb1-b082-716f-c2e129d27c48@suse.cz> (raw)
In-Reply-To: <20200302193630.68771-6-minchan@kernel.org>
On 3/2/20 8:36 PM, Minchan Kim wrote:
> There is a demand[1] to support pid as well pidfd for process_madvise
> to reduce unnecessary syscall to get pidfd if the user has control of
> the target process(ie, they could guarantee the process is not gone
> or pid is not reused).
>
> This patch aims for supporting both options like waitid(2). So, the
> syscall is currently,
>
> int process_madvise(int which, pid_t pid, void *addr,
> size_t length, int advise, unsigned long flag);
This is again halfway between kernel and userspace description, so if we stick
to userspace then it's:
int process_madvise(idtype_t idtype, id_t id, void *addr,
size_t length, int advice, unsigned long flags);
> @which is actually idtype_t for userspace libray and currently,
> it supports P_PID and P_PIDFD.
>
> [1] https://lore.kernel.org/linux-mm/9d849087-3359-c4ab-fbec-859e8186c509@virtuozzo.com/
>
> Cc: Christian Brauner <christian@brauner.io>
> Reviewed-by: Suren Baghdasaryan <surenb@google.com>
> Suggested-by: Kirill Tkhai <ktkhai@virtuozzo.com>
> Signed-off-by: Minchan Kim <minchan@kernel.org>
Reviewed-by: Vlastimil Babka <vbabka@suse.cz>
next prev parent reply other threads:[~2020-03-06 11:14 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-02 19:36 [PATCH v7 0/7] introduce memory hinting API for external process Minchan Kim
2020-03-02 19:36 ` [PATCH v7 1/7] mm: pass task and mm to do_madvise Minchan Kim
2020-03-05 15:48 ` Vlastimil Babka
2020-05-08 18:21 ` Minchan Kim
2020-03-02 19:36 ` [PATCH v7 2/7] mm: introduce external memory hinting API Minchan Kim
2020-03-03 10:33 ` kbuild test robot
2020-03-03 10:33 ` kbuild test robot
2020-03-03 14:57 ` Minchan Kim
2020-03-03 14:57 ` Minchan Kim
2020-03-05 18:15 ` Vlastimil Babka
2020-03-10 22:20 ` Minchan Kim
2020-03-11 0:36 ` Minchan Kim
2020-03-12 12:40 ` Vlastimil Babka
2020-03-12 20:23 ` Minchan Kim
2020-05-08 18:33 ` Minchan Kim
2020-03-02 19:36 ` [PATCH v7 3/7] mm: check fatal signal pending of target process Minchan Kim
2020-03-06 10:22 ` Vlastimil Babka
2020-03-10 22:24 ` Minchan Kim
2020-03-02 19:36 ` [PATCH v7 4/7] pid: move pidfd_get_pid function to pid.c Minchan Kim
2020-03-06 10:57 ` Vlastimil Babka
2020-03-06 11:14 ` Christian Brauner
2020-03-02 19:36 ` [PATCH v7 5/7] mm: support both pid and pidfd for process_madvise Minchan Kim
2020-03-06 11:14 ` Vlastimil Babka [this message]
2020-03-11 0:42 ` Minchan Kim
2020-05-08 18:36 ` Minchan Kim
2020-05-08 23:04 ` Andrew Morton
2020-05-09 12:48 ` Christian Brauner
2020-05-09 23:14 ` Minchan Kim
2020-05-12 19:55 ` Suren Baghdasaryan
2020-05-12 19:55 ` Suren Baghdasaryan
2020-03-02 19:36 ` [PATCH v7 6/7] mm/madvise: employ mmget_still_valid for write lock Minchan Kim
2020-03-06 12:52 ` Vlastimil Babka
2020-03-06 13:03 ` Oleksandr Natalenko
2020-03-06 16:03 ` Vlastimil Babka
2020-03-09 12:30 ` Oleksandr Natalenko
2020-03-10 22:28 ` Minchan Kim
2020-03-02 19:36 ` [PATCH v7 7/7] mm/madvise: allow KSM hints for remote API Minchan Kim
2020-03-06 13:13 ` Vlastimil Babka
2020-03-06 13:41 ` Oleksandr Natalenko
2020-03-06 16:08 ` Vlastimil Babka
2020-03-09 13:11 ` Oleksandr Natalenko
2020-03-09 15:08 ` Michal Hocko
2020-03-09 15:19 ` Oleksandr Natalenko
2020-03-09 15:42 ` Vlastimil Babka
2020-03-09 16:03 ` Michal Hocko
2020-06-11 2:21 ` Jann Horn
2020-06-11 2:21 ` Jann Horn
2020-03-02 21:16 ` [PATCH v7 0/7] introduce memory hinting API for external process Andrew Morton
2020-03-02 21:42 ` Minchan Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=14089609-5fb1-b082-716f-c2e129d27c48@suse.cz \
--to=vbabka@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=alexander.h.duyck@linux.intel.com \
--cc=bgeffon@google.com \
--cc=christian@brauner.io \
--cc=dancol@google.com \
--cc=hannes@cmpxchg.org \
--cc=jannh@google.com \
--cc=joaodias@google.com \
--cc=joel@joelfernandes.org \
--cc=ktkhai@virtuozzo.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=minchan@kernel.org \
--cc=oleksandr@redhat.com \
--cc=shakeelb@google.com \
--cc=sj38.park@gmail.com \
--cc=sonnyrao@google.com \
--cc=sspatil@google.com \
--cc=surenb@google.com \
--cc=timmurray@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.