All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: kwolf@redhat.com, lersek@redhat.com, qemu-devel@nongnu.org,
	stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH 1/2] usb: Fix bootindex for portnr > 9
Date: Mon, 25 Aug 2014 14:48:56 +0200	[thread overview]
Message-ID: <1408970936.24970.17.camel@nilsson.home.kraxel.org> (raw)
In-Reply-To: <1408102357-914-2-git-send-email-armbru@redhat.com>

On Fr, 2014-08-15 at 13:32 +0200, Markus Armbruster wrote:
> We identify devices by their Open Firmware device paths.  The encoding
> of the host controller and hub port numbers is incorrect:
> usb_get_fw_dev_path() formats them in decimal, while SeaBIOS uses
> hexadecimal.  When some port number > 9, SeaBIOS will miss the
> bootindex (lucky case), or apply it to another device (unlucky case).
> 
> The relevant spec[*] agrees with SeaBIOS (and OVMF, for that matter).
> Change %d to %x.
> 
> Bug can bite only with host controllers or hubs sporting more than ten
> ports.  I'm not aware of any.

fyi: xhci can be configured with up to 15 ports (default is 4 ports
though).

Applied to usb patch queue.

thanks,
  Gerd

  reply	other threads:[~2014-08-25 12:49 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-15 11:32 [Qemu-devel] [PATCH 0/2] Fix latent(?) bootindex bugs Markus Armbruster
2014-08-15 11:32 ` [Qemu-devel] [PATCH 1/2] usb: Fix bootindex for portnr > 9 Markus Armbruster
2014-08-25 12:48   ` Gerd Hoffmann [this message]
2014-08-25 14:33     ` Markus Armbruster
2014-08-15 11:32 ` [Qemu-devel] [PATCH 2/2] ide: Fix bootindex for bus_id " Markus Armbruster
2014-08-26 10:51   ` Stefan Hajnoczi
2014-08-15 11:55 ` [Qemu-devel] [PATCH 0/2] Fix latent(?) bootindex bugs Laszlo Ersek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1408970936.24970.17.camel@nilsson.home.kraxel.org \
    --to=kraxel@redhat.com \
    --cc=armbru@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=lersek@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.