All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Glass <sjg@chromium.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v9 10/14] buildman: Remove the directory prefix from each error line
Date: Mon, 25 Aug 2014 09:58:31 -0600	[thread overview]
Message-ID: <1408982315-18610-11-git-send-email-sjg@chromium.org> (raw)
In-Reply-To: <1408982315-18610-1-git-send-email-sjg@chromium.org>

The full path is long and also includes buildman private directories.
Clean this up, so that only a relative U-Boot path is shown.

This will change warnings like these:

/home/sjg/c/src/third_party/u-boot/buildman5/.bm-work/00/arch/sandbox/cpu/cpu.c: In function 'timer_get_us':
/home/sjg/c/src/third_party/u-boot/buildman5/.bm-work/00/arch/sandbox/cpu/cpu.c:40:9: warning: unused variable 'i' [-Wunused-variable]

/home/sjg/c/src/third_party/u-boot/files/arch/sandbox/cpu/cpu.c: In function 'timer_get_us':
/home/sjg/c/src/third_party/u-boot/files/arch/sandbox/cpu/cpu.c:40:9: warning: unused variable 'i' [-Wunused-variable]

to:

arch/sandbox/cpu/cpu.c: In function 'timer_get_us':
arch/sandbox/cpu/cpu.c:40:9: warning: unused variable 'i' [-Wunused-variable]

Signed-off-by: Simon Glass <sjg@chromium.org>
---

Changes in v9:
- Add new patch to remove the directory prefix from each error line

Changes in v8: None
Changes in v7: None
Changes in v6: None
Changes in v5: None

 tools/buildman/builderthread.py | 22 +++++++++++++++++++++-
 1 file changed, 21 insertions(+), 1 deletion(-)

diff --git a/tools/buildman/builderthread.py b/tools/buildman/builderthread.py
index 8214662..7fb24bc 100644
--- a/tools/buildman/builderthread.py
+++ b/tools/buildman/builderthread.py
@@ -103,6 +103,23 @@ class BuilderThread(threading.Thread):
         return self.builder.do_make(commit, brd, stage, cwd, *args,
                 **kwargs)
 
+    def _FilterOutDir(self, text, dirname):
+        """Filter out a directory name from each line of a block of text
+
+        Args:
+            text: Text to process (can be multiple lines separated by \n)
+            dirname: Directory name to remove from the start of each text
+                line
+        Returns:
+            Filtered text.
+        """
+        out = []
+        for line in text.split('\n'):
+            if line.startswith(dirname):
+                line = line[len(dirname):]
+            out.append(line)
+        return '\n'.join(out)
+
     def RunCommit(self, commit_upto, brd, work_dir, do_config, force_build,
                   force_build_failures):
         """Build a particular commit.
@@ -177,6 +194,7 @@ class BuilderThread(threading.Thread):
                 Mkdir(out_dir)
                 args = []
                 cwd = work_dir
+                src_dir = os.path.realpath(work_dir)
                 if not self.builder.in_tree:
                     if commit_upto is None:
                         # In this case we are building in the original source
@@ -189,6 +207,7 @@ class BuilderThread(threading.Thread):
                         work_dir = os.path.realpath(work_dir)
                         args.append('O=%s/build' % work_dir)
                         cwd = None
+                        src_dir = os.getcwd()
                     else:
                         args.append('O=build')
                 args.append('-s')
@@ -209,7 +228,8 @@ class BuilderThread(threading.Thread):
                 if result.return_code == 0:
                     result = self.Make(commit, brd, 'build', cwd, *args,
                             env=env)
-                    result.stdout = config_out + result.stdout
+                    result.stderr = self._FilterOutDir(result.stderr,
+                                            src_dir + '/')
             else:
                 result.return_code = 1
                 result.stderr = 'No tool chain for %s\n' % brd.arch
-- 
2.1.0.rc2.206.gedb03e5

  parent reply	other threads:[~2014-08-25 15:58 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-25 15:58 [U-Boot] [PATCH v9 0/14] Add some missing buildman features and deprecate MAKEALL Simon Glass
2014-08-25 15:58 ` [U-Boot] [PATCH v9 01/14] patman: Support the 'reverse' option for 'git log' Simon Glass
2014-08-25 15:58 ` [U-Boot] [PATCH v9 02/14] patman: Fix indentation in terminal.py Simon Glass
2014-08-25 15:58 ` [U-Boot] [PATCH v9 03/14] patman: Correct unit tests to run correctly Simon Glass
2014-08-25 15:58 ` [U-Boot] [PATCH v9 04/14] patman: Remove the -a option Simon Glass
2014-08-25 15:58 ` [U-Boot] [PATCH v9 05/14] patman: Use --no-pager' to stop git from forking a pager Simon Glass
2014-08-25 15:58 ` [U-Boot] [PATCH v9 06/14] patman: Avoid changing the order of tags Simon Glass
2014-08-25 15:58 ` [U-Boot] [PATCH v9 07/14] buildman: Set the return code to indicate build result Simon Glass
2014-08-25 15:58 ` [U-Boot] [PATCH v9 08/14] buildman: Allow make-flags variables to include '-' and '_' Simon Glass
2014-08-25 15:58 ` [U-Boot] [PATCH v9 09/14] buildman: Implement an option to exclude boards from the build Simon Glass
2014-08-25 15:58 ` Simon Glass [this message]
2014-08-26 14:13   ` [U-Boot] [PATCH v9 10/14] buildman: Remove the directory prefix from each error line Tom Rini
2014-08-27  3:00     ` Simon Glass
2014-08-25 15:58 ` [U-Boot] [PATCH v9 11/14] buildman: Add an option to show which boards caused which errors Simon Glass
2014-08-25 19:14   ` Tom Rini
2014-08-26 14:09     ` Tom Rini
2014-08-27  2:59     ` Simon Glass
2014-08-28 12:51       ` Tom Rini
2014-09-01  5:09         ` Simon Glass
2014-09-01 11:23           ` Tom Rini
2014-09-02  0:18             ` Simon Glass
2014-08-25 15:58 ` [U-Boot] [PATCH v9 12/14] buildman: Separate out display of warnings and errors Simon Glass
2014-08-25 15:58 ` [U-Boot] [PATCH v9 13/14] patman: Fix detection of git version Simon Glass
2014-08-25 15:58 ` [U-Boot] [PATCH v9 14/14] RFC: Deprecate MAKEALL Simon Glass
2014-08-25 18:54 ` [U-Boot] [PATCH v9 0/14] Add some missing buildman features and deprecate MAKEALL Tom Rini
2014-08-25 19:00   ` Simon Glass
2014-08-25 20:21     ` Tom Rini
2014-08-27  2:54       ` Simon Glass
2014-08-28 12:48         ` Tom Rini
2014-09-01  5:07           ` Simon Glass
2014-09-04 18:25             ` Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1408982315-18610-11-git-send-email-sjg@chromium.org \
    --to=sjg@chromium.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.