From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF780C61DA4 for ; Mon, 6 Feb 2023 11:18:25 +0000 (UTC) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0424C42D1A; Mon, 6 Feb 2023 12:18:25 +0100 (CET) Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by mails.dpdk.org (Postfix) with ESMTP id 6963340A7A for ; Mon, 6 Feb 2023 12:18:23 +0100 (CET) Received: from dggpeml500024.china.huawei.com (unknown [172.30.72.56]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4P9Nx84S8xz16NR4; Mon, 6 Feb 2023 19:16:12 +0800 (CST) Received: from [10.67.100.224] (10.67.100.224) by dggpeml500024.china.huawei.com (7.185.36.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Mon, 6 Feb 2023 19:18:21 +0800 Subject: Re: [PATCH v8 2/5] eal: report applications lcore usage To: =?UTF-8?Q?Morten_Br=c3=b8rup?= , Robin Jarry , CC: Kevin Laatz References: <20221123102612.1688865-1-rjarry@redhat.com> <20230202134329.539625-1-rjarry@redhat.com> <20230202134329.539625-3-rjarry@redhat.com> <134bf55e-ff9b-4ab0-bb16-3347f7b3c95f@huawei.com> <98CBD80474FA8B44BF855DF32C47DC35D876FF@smartserver.smartshare.dk> From: fengchengwen Message-ID: <1408d0b8-7c7c-33be-3131-8352b3ac8fa3@huawei.com> Date: Mon, 6 Feb 2023 19:18:21 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35D876FF@smartserver.smartshare.dk> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.100.224] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To dggpeml500024.china.huawei.com (7.185.36.10) X-CFilter-Loop: Reflected X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2023/2/6 15:36, Morten Brørup wrote: >> From: fengchengwen [mailto:fengchengwen@huawei.com] >> Sent: Monday, 6 February 2023 05.00 >> >> Hi Robin, >> >> On 2023/2/2 21:43, Robin Jarry wrote: >>> Allow applications to register a callback that will be invoked in >>> rte_lcore_dump() and when requesting lcore info in the telemetry API. >>> >>> The callback is expected to return the number of TSC cycles that have >>> passed since application start and the number of these cycles that >> were >>> spent doing busy work. >>> >> >> The 'record_burst_stats' also important for performance tune. > > While I agree that burst size spread is important for comparing CPU usage and capacity, the 'record_burst_stats' is a test_pmd specific feature. Applications may implement something different. > >> >> Is it possible to incorporate it into this framework? > > We all agreed on CPU usage metrics for this patch, so let's limit ourselves this time. > > If we want more performance metrics, such as RX and TX burst size spread, they can be proposed and discussed in a separate RFC. It might trigger a lot of discussion, like the original lcore busyness patch that inspired this patch series. > It's okay for a separate RFC.