From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752690AbaH1Xbc (ORCPT ); Thu, 28 Aug 2014 19:31:32 -0400 Received: from g4t3426.houston.hp.com ([15.201.208.54]:18940 "EHLO g4t3426.houston.hp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752474AbaH1Xba (ORCPT ); Thu, 28 Aug 2014 19:31:30 -0400 Message-ID: <1409268069.28990.120.camel@misato.fc.hp.com> Subject: Re: [PATCH 2/3] x86: Enable PAT to use cache mode translation tables From: Toshi Kani To: Juergen Gross Cc: stefan.bader@canonical.com, linux-kernel@vger.kernel.org, xen-devel@lists.xensource.com, konrad.wilk@oracle.com, ville.syrjala@linux.intel.com, hpa@zytor.com, x86@kernel.org Date: Thu, 28 Aug 2014 17:21:09 -0600 In-Reply-To: <1409033783-12136-3-git-send-email-jgross@suse.com> References: <1409033783-12136-1-git-send-email-jgross@suse.com> <1409033783-12136-3-git-send-email-jgross@suse.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.8.5 (3.8.5-2.fc19) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2014-08-26 at 08:16 +0200, Juergen Gross wrote: > Update the translation tables from cache mode to pgprot values according to > the PAT settings. This enables changing the cache attributes of a PAT index in > just one place without having to change at the users side. > > With this change it is possible to use the same kernel with different PAT > configurations, e.g. supporting Xen. > > Signed-off-by: Juergen Gross I know I sent my review-by before, but my build test failed... > diff --git a/include/linux/mm.h b/include/linux/mm.h > index 8981cc8..d7bf551 100644 > --- a/include/linux/mm.h > +++ b/include/linux/mm.h > @@ -1574,6 +1574,7 @@ extern void free_area_init(unsigned long * zones_size); > extern void free_area_init_node(int nid, unsigned long * zones_size, > unsigned long zone_start_pfn, unsigned long *zholes_size); > extern void free_initmem(void); > +extern void update_cache_mode_entry(unsigned entry, enum page_cache_mode cache); This new interface cannot be defined in this common header file since page_cache_mode is only defined in x86. It should be defined in x86 header, such as pat.h. Thanks, -Toshi