All of lore.kernel.org
 help / color / mirror / Atom feed
From: <arei.gonglei@huawei.com>
To: qemu-devel@nongnu.org
Cc: chenliang88@huawei.com, weidong.huang@huawei.com, mst@redhat.com,
	aik@ozlabs.ru, hutao@cn.fujitsu.com, armbru@redhat.com,
	kraxel@redhat.com, akong@redhat.com, agraf@suse.de,
	Gonglei <arei.gonglei@huawei.com>,
	aliguori@amazon.com, ehabkost@redhat.com, luonengjun@huawei.com,
	peter.huangpeng@huawei.com, hani@linux.com, stefanha@redhat.com,
	pbonzini@redhat.com, lcapitulino@redhat.com, kwolf@redhat.com,
	peter.crosthwaite@xilinx.com, imammedo@redhat.com,
	afaerber@suse.de
Subject: [Qemu-devel] [PATCH v6 18/27] host-libusb: remove bootindex property from qdev to qom
Date: Sat, 30 Aug 2014 18:00:18 +0800	[thread overview]
Message-ID: <1409392827-9372-19-git-send-email-arei.gonglei@huawei.com> (raw)
In-Reply-To: <1409392827-9372-1-git-send-email-arei.gonglei@huawei.com>

From: Gonglei <arei.gonglei@huawei.com>

Remove bootindex form qdev property to qom, things will
continue to work just fine, and we can use qom features
which are not supported by qdev property.

Signed-off-by: Gonglei <arei.gonglei@huawei.com>
---
 hw/usb/host-libusb.c | 26 +++++++++++++++++++++++++-
 1 file changed, 25 insertions(+), 1 deletion(-)

diff --git a/hw/usb/host-libusb.c b/hw/usb/host-libusb.c
index f37708d..c3c91f3 100644
--- a/hw/usb/host-libusb.c
+++ b/hw/usb/host-libusb.c
@@ -979,6 +979,30 @@ static int usb_host_initfn(USBDevice *udev)
     return 0;
 }
 
+static void usb_host_get_bootindex(Object *obj, Visitor *v, void *opaque,
+                                   const char *name, Error **errp)
+{
+    USBHostDevice *s = USB_HOST_DEVICE(obj);
+
+    get_bootindex(&s->bootindex, v, name, errp);
+}
+
+static void usb_host_set_bootindex(Object *obj, Visitor *v, void *opaque,
+                                   const char *name, Error **errp)
+{
+    USBHostDevice *s = USB_HOST_DEVICE(obj);
+
+    set_bootindex(&s->bootindex, v, name, errp);
+}
+
+static void usb_host_instance_init(Object *obj)
+{
+    object_property_add(obj, "bootindex", "int",
+                        usb_host_get_bootindex,
+                        usb_host_set_bootindex, NULL, NULL, NULL);
+    object_property_set_int(obj, -1, "bootindex", NULL);
+}
+
 static void usb_host_handle_destroy(USBDevice *udev)
 {
     USBHostDevice *s = USB_HOST_DEVICE(udev);
@@ -1465,7 +1489,6 @@ static Property usb_host_dev_properties[] = {
     DEFINE_PROP_UINT32("productid", USBHostDevice, match.product_id, 0),
     DEFINE_PROP_UINT32("isobufs",  USBHostDevice, iso_urb_count,    4),
     DEFINE_PROP_UINT32("isobsize", USBHostDevice, iso_urb_frames,   32),
-    DEFINE_PROP_INT32("bootindex", USBHostDevice, bootindex,        -1),
     DEFINE_PROP_UINT32("loglevel",  USBHostDevice, loglevel,
                        LIBUSB_LOG_LEVEL_WARNING),
     DEFINE_PROP_BIT("pipeline",    USBHostDevice, options,
@@ -1498,6 +1521,7 @@ static TypeInfo usb_host_dev_info = {
     .parent        = TYPE_USB_DEVICE,
     .instance_size = sizeof(USBHostDevice),
     .class_init    = usb_host_class_initfn,
+    .instance_init = usb_host_instance_init,
 };
 
 static void usb_host_register_types(void)
-- 
1.7.12.4

  parent reply	other threads:[~2014-08-30 10:01 UTC|newest]

Thread overview: 58+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-30 10:00 [Qemu-devel] [PATCH v6 00/27] modify boot order of guest, and take effect after rebooting arei.gonglei
2014-08-30 10:00 ` [Qemu-devel] [PATCH v6 01/27] bootindex: add check bootindex function arei.gonglei
2014-08-30 10:00 ` [Qemu-devel] [PATCH v6 02/27] bootindex: add del_boot_device_path function arei.gonglei
2014-09-01  6:43   ` Gerd Hoffmann
2014-09-01  6:47     ` Gonglei (Arei)
2014-09-02 18:00       ` Eduardo Habkost
2014-09-03  2:35         ` Gonglei (Arei)
2014-09-03  6:24           ` Gerd Hoffmann
2014-09-03  6:45             ` Gonglei (Arei)
2014-09-03 18:13               ` Eduardo Habkost
2014-09-04  3:01                 ` Gonglei (Arei)
2014-09-04 13:22                   ` Eduardo Habkost
2014-09-05  0:44                     ` Gonglei (Arei)
2014-09-05  2:20                       ` Eduardo Habkost
2014-09-05  2:42                         ` Gonglei (Arei)
2014-09-05 14:56                           ` Eduardo Habkost
2014-09-04  6:15                 ` Gonglei (Arei)
2014-09-04 11:48                   ` Gonglei (Arei)
2014-09-04 12:06                     ` Gonglei (Arei)
2014-09-03  2:40         ` Gonglei (Arei)
2014-08-30 10:00 ` [Qemu-devel] [PATCH v6 03/27] fw_cfg: add fw_cfg_machine_reset function arei.gonglei
2014-08-30 10:00 ` [Qemu-devel] [PATCH v6 04/27] bootindex: rework add_boot_device_path function arei.gonglei
2014-08-30 10:00 ` [Qemu-devel] [PATCH v6 05/27] bootindex: support to set a existent device's bootindex to -1 arei.gonglei
2014-08-30 10:00 ` [Qemu-devel] [PATCH v6 06/27] bootindex: move setting bootindex on reset() instead of realize/init() arei.gonglei
2014-09-04 14:50   ` Eduardo Habkost
2014-09-05  0:09     ` Gonglei (Arei)
2014-08-30 10:00 ` [Qemu-devel] [PATCH v6 07/27] vl.c: add setter/getter functions for bootindex property arei.gonglei
2014-08-31  9:58   ` Michael S. Tsirkin
2014-09-01  1:02     ` Gonglei (Arei)
2014-09-03  7:47   ` Gonglei (Arei)
2014-09-03  8:20     ` Gerd Hoffmann
2014-09-03  8:37       ` Gonglei (Arei)
2014-09-04 15:01   ` Eduardo Habkost
2014-09-05  0:37     ` Gonglei (Arei)
2014-09-05  1:55       ` Eduardo Habkost
2014-09-05  2:07         ` Gonglei (Arei)
2014-09-05  2:21           ` Eduardo Habkost
2014-09-05  2:44             ` Gonglei (Arei)
2014-08-30 10:00 ` [Qemu-devel] [PATCH v6 08/27] virtio-net: add bootindex to qom property arei.gonglei
2014-08-30 10:00 ` [Qemu-devel] [PATCH v6 09/27] e1000: " arei.gonglei
2014-08-30 10:00 ` [Qemu-devel] [PATCH v6 10/27] eepro100: " arei.gonglei
2014-08-30 10:00 ` [Qemu-devel] [PATCH v6 11/27] ne2000: " arei.gonglei
2014-08-30 10:00 ` [Qemu-devel] [PATCH v6 12/27] pcnet: " arei.gonglei
2014-08-30 10:00 ` [Qemu-devel] [PATCH v6 13/27] rtl8139: " arei.gonglei
2014-08-30 10:00 ` [Qemu-devel] [PATCH v6 14/27] spapr_lian: " arei.gonglei
2014-08-30 10:00 ` [Qemu-devel] [PATCH v6 15/27] vmxnet3: " arei.gonglei
2014-08-30 10:00 ` [Qemu-devel] [PATCH v6 16/27] usb-net: " arei.gonglei
2014-08-30 10:00 ` [Qemu-devel] [PATCH v6 17/27] net: remove bootindex property from qdev to qom arei.gonglei
2014-08-30 10:00 ` arei.gonglei [this message]
2014-08-30 10:00 ` [Qemu-devel] [PATCH v6 19/27] pci-assign: " arei.gonglei
2014-08-30 10:00 ` [Qemu-devel] [PATCH v6 20/27] vfio: " arei.gonglei
2014-08-30 10:00 ` [Qemu-devel] [PATCH v6 21/27] redirect: " arei.gonglei
2014-08-30 10:00 ` [Qemu-devel] [PATCH v6 22/27] isa-fdc: remove bootindexA/B " arei.gonglei
2014-08-30 10:00 ` [Qemu-devel] [PATCH v6 23/27] ide: add bootindex to qom property arei.gonglei
2014-08-30 10:00 ` [Qemu-devel] [PATCH v6 24/27] scsi: " arei.gonglei
2014-08-30 10:00 ` [Qemu-devel] [PATCH v6 25/27] virtio-blk: " arei.gonglei
2014-08-30 10:00 ` [Qemu-devel] [PATCH v6 26/27] block: remove bootindex property from qdev to qom arei.gonglei
2014-08-30 10:00 ` [Qemu-devel] [PATCH v6 27/27] bootindex: delete bootindex when device is removed arei.gonglei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1409392827-9372-19-git-send-email-arei.gonglei@huawei.com \
    --to=arei.gonglei@huawei.com \
    --cc=afaerber@suse.de \
    --cc=agraf@suse.de \
    --cc=aik@ozlabs.ru \
    --cc=akong@redhat.com \
    --cc=aliguori@amazon.com \
    --cc=armbru@redhat.com \
    --cc=chenliang88@huawei.com \
    --cc=ehabkost@redhat.com \
    --cc=hani@linux.com \
    --cc=hutao@cn.fujitsu.com \
    --cc=imammedo@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=lcapitulino@redhat.com \
    --cc=luonengjun@huawei.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.crosthwaite@xilinx.com \
    --cc=peter.huangpeng@huawei.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    --cc=weidong.huang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.