From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH] numa.c: use spaces instead of tabs Date: Wed, 3 Sep 2014 13:18:12 +0100 Message-ID: <1409746692.20794.14.camel@citrix.com> References: <1409717890-2837-1-git-send-email-ufimtseva@gmail.com> <1409737969.2673.35.camel@Solace.lan> <54070330020000780003029A@mail.emea.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Elena Ufimtseva Cc: Keir Fraser , George Dunlap , Dario Faggioli , Ian Jackson , "xen-devel@lists.xen.org" , Jan Beulich List-Id: xen-devel@lists.xenproject.org On Wed, 2014-09-03 at 07:59 -0400, Elena Ufimtseva wrote: > On Wed, Sep 3, 2014 at 6:01 AM, Jan Beulich wrote: > >>>> On 03.09.14 at 11:52, wrote: > >> On mer, 2014-09-03 at 00:18 -0400, Elena Ufimtseva wrote: > >>> Signed-off-by: Elena Ufimtseva > >>> --- > >>> > >> I think the patch does what the subject says, i.e., converting tabs to > >> spaces, and does it right (I've only one question, see below). > >> > >> However, does it make sense, while at it, to turn the file into a Xen's > >> code stile compliant one? Because, if yes, there are other things than > >> tabs-->spaces that needs fixing, I believe. > > > > Yes, indeed - we don't use a style like what results from this patch. > > > >>> @@ -121,83 +121,83 @@ static int __init > >> allocate_cachealigned_memnodemap(void) > >>> * maximum possible shift. > >>> */ > >>> static int __init extract_lsb_from_nodes(const struct node *nodes, > >>> - int numnodes) > >>> + int numnodes) > >>> > >> Perhaps I am the one missing something here, but shouldn't this still be > >> aligned to the '(' above (through spaces, of course)? > > > > Indeed it should. > > > > Jan > > > > > Dario, Jan > > True to that there are few other things that should be fixed in > regards to the style. > > But about the tabs/spaces what patch attempt to change, as it says. > > Jan, you say that such style is not used.. But numa.c uses tabs as > :set list shows and its not Xen style either. > Coding style says - 4 spaces for one level of indent. numa.c uses tabs > and sometimes space between tabs. > > I am looking at the rest of the files in xen/arch/x86/ and see that > they have all same tab= 4 spaces for indentation. > for example see xen/arch/x86/domain.c. > I used this for vim to re-tab the file: set noai ts=4 sw=8 expandtab I think what Jan meant was that simply changing tabs->spaces did not result in any valid coding style, since Xen style differs from the result in other ways too (e.g. spacing inside the spaces surrounding expressions). > Linux has 8 spaces for tabs.. So I am lost here. Was numa.c imported from Linux? In such cases we often (try to) stick with Linux style. Ian.