From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <Ian.Campbell@citrix.com>
Subject: Re: [PATCH v10 8/9] libxl: vnuma nodes placement bits
Date: Wed, 3 Sep 2014 16:52:16 +0100
Message-ID: <1409759536.3323.39.camel@kazak.uk.xensource.com>
References: <1409718258-3276-1-git-send-email-ufimtseva@gmail.com>
	<1409718258-3276-6-git-send-email-ufimtseva@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1409718258-3276-6-git-send-email-ufimtseva@gmail.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Elena Ufimtseva <ufimtseva@gmail.com>
Cc: keir@xen.org, stefano.stabellini@eu.citrix.com, george.dunlap@eu.citrix.com, msw@linux.com, dario.faggioli@citrix.com, lccycc123@gmail.com, ian.jackson@eu.citrix.com, xen-devel@lists.xen.org, JBeulich@suse.com
List-Id: xen-devel@lists.xenproject.org

On Wed, 2014-09-03 at 00:24 -0400, Elena Ufimtseva wrote:

> +    /* default setting. */
> +    for (i = 0; i < info->vnodes; i++)
> +        info->vnuma_vnodemap[i] = LIBXC_VNUMA_NO_NODE;

What if the user had specified this?

> +static int libxl__build_vnuma_ranges(libxl__gc *gc,
> +                              uint32_t domid,
> +                              /* IN: mem sizes in megabytes */
> +                              libxl_domain_build_info *b_info,

const please.

> +                              /* OUT: linux NUMA blocks addresses */

More Linux specifics.

> +                              vmemrange_t **memrange)
> +{
> +    /*
> +     * For non-PV domains, contruction of the regions will

"construction"

> +    b_info->vmemranges = b_info->vnodes;

What if the user had specified vmemranges themselves?

Actually, I'm becomign increasingly confused about the fields in the
libxl interface, so I think I'm going to go back to patch #5 to clarify
that before I try to understand any more of this code.

Ian.