All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hannes Frederic Sowa <hannes@stressinduktion.org>
To: Cong Wang <xiyou.wangcong@gmail.com>, netdev@vger.kernel.org
Cc: Sabrina Dubroca <sd@queasysnail.net>,
	"David S. Miller" <davem@davemloft.net>
Subject: Re: [Patch net] ipv6: restore the behavior of ipv6_sock_ac_drop()
Date: Sat, 06 Sep 2014 00:26:25 +0200	[thread overview]
Message-ID: <1409955985.1192797.164218289.4192DDA7@webmail.messagingengine.com> (raw)
In-Reply-To: <1409952780-24471-1-git-send-email-xiyou.wangcong@gmail.com>

Hi Cong,

Just doing normal review, really no bad intentions, just technical
follow-up. ;)

On Fri, Sep 5, 2014, at 23:33, Cong Wang wrote:
> It is possible that the interface is already gone after joining
> the list of anycast on this interface as we don't hold a refcount
> for the device, in this case we are safe to ignore the error.

anycast code actually inserts routes into the routing table and holds a
reference on the interface while that route is active.

> What's more important, for API compatibility we should not
> change this behavior for applications even if it were correct.

IMHO adding new error codes never breaks existing applications because
there is no way they can explore all possible errno variables. Also we
already report ENODEV from multicast setsockopts. So I think it would be
ok to leave it as is, but I have no strong opinion on that and it would
be ok by me if the patch got accepted (maybe update the changelog).

Thanks,
Hannes

  reply	other threads:[~2014-09-05 22:26 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-05 21:33 [Patch net] ipv6: restore the behavior of ipv6_sock_ac_drop() Cong Wang
2014-09-05 22:26 ` Hannes Frederic Sowa [this message]
2014-09-05 22:41   ` Cong Wang
2014-09-05 23:07     ` Hannes Frederic Sowa
2014-09-07 23:10 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1409955985.1192797.164218289.4192DDA7@webmail.messagingengine.com \
    --to=hannes@stressinduktion.org \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=sd@queasysnail.net \
    --cc=xiyou.wangcong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.