All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: qemu-devel@nongnu.org
Cc: Jan Kiszka <jan.kiszka@siemens.com>,
	qemu-stable@nongnu.org, Anthony Liguori <aliguori@amazon.com>
Subject: [Qemu-devel] [PATCH] virtio-pci: enable bus master for old guests
Date: Mon, 8 Sep 2014 19:05:02 +0300	[thread overview]
Message-ID: <1410192283-4026-1-git-send-email-mst@redhat.com> (raw)

commit cc943c36faa192cd4b32af8fe5edb31894017d35
    pci: Use bus master address space for delivering MSI/MSI-X messages
breaks virtio-net for rhel6.[56] x86 guests because they don't
enable bus mastering for virtio PCI devices

Old guests forgot to enable bus mastering, enable it
automatically on DRIVER_OK.

Note: we should either back out the original patch from
stable or apply this one on top.

Cc: qemu-stable@nongnu.org
Reported-by: Greg Kurz <gkurz@linux.vnet.ibm.com>
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
 hw/virtio/virtio-pci.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c
index ddb5da1..af937d2 100644
--- a/hw/virtio/virtio-pci.c
+++ b/hw/virtio/virtio-pci.c
@@ -320,6 +320,8 @@ static void virtio_ioport_write(void *opaque, uint32_t addr, uint32_t val)
         if ((val & VIRTIO_CONFIG_S_DRIVER_OK) &&
             !(proxy->pci_dev.config[PCI_COMMAND] & PCI_COMMAND_MASTER)) {
             proxy->flags |= VIRTIO_PCI_FLAG_BUS_MASTER_BUG;
+            memory_region_set_enabled(&proxy->pci_dev.bus_master_enable_region,
+                                      true);
         }
         break;
     case VIRTIO_MSI_CONFIG_VECTOR:
-- 
MST

             reply	other threads:[~2014-09-08 16:02 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-08 16:05 Michael S. Tsirkin [this message]
2014-09-08 16:26 ` [Qemu-devel] [PATCH] virtio-pci: enable bus master for old guests Jan Kiszka
2014-09-08 16:35   ` Michael S. Tsirkin
2014-09-09 14:13 ` Michael Roth
2014-09-09 14:27   ` Michael S. Tsirkin
2014-09-09 22:35 ` Greg Kurz
2014-09-10  2:39   ` Alexey Kardashevskiy
2014-09-10  8:14   ` Nikunj A Dadhania
2014-09-10  8:58     ` Greg Kurz
2014-09-10  9:32     ` Michael S. Tsirkin
2014-09-10  9:01       ` Greg Kurz
2014-09-10  9:18         ` Nikunj A Dadhania
2014-09-10 11:27         ` Michael S. Tsirkin
2014-09-10  9:15       ` Nikunj A Dadhania
2014-09-10 10:54         ` Michael S. Tsirkin
2014-09-10  9:26   ` Michael S. Tsirkin
2014-09-11 16:45 Greg Kurz
2014-09-11 17:47 ` Michael S. Tsirkin
2014-09-11 17:50   ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1410192283-4026-1-git-send-email-mst@redhat.com \
    --to=mst@redhat.com \
    --cc=aliguori@amazon.com \
    --cc=jan.kiszka@siemens.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-stable@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.