From: Joe Perches <joe@perches.com>
To: Greg Donald <gdonald@gmail.com>
Cc: Greg Kroah-Hartman <greg@kroah.com>,
Andreas Dilger <andreas.dilger@intel.com>,
Oleg Drokin <oleg.drokin@intel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers: staging: lustre: Fix "space prohibited after that open parenthesis '('" errors
Date: Mon, 08 Sep 2014 15:38:01 -0700 [thread overview]
Message-ID: <1410215881.12560.21.camel@joe-AO725> (raw)
In-Reply-To: <1410215528-22856-1-git-send-email-gdonald@gmail.com>
On Mon, 2014-09-08 at 17:32 -0500, Greg Donald wrote:
> Fix checkpatch.pl "space prohibited after that open parenthesis '('" errors
[]
> diff --git a/drivers/staging/lustre/lustre/obdclass/obdo.c b/drivers/staging/lustre/lustre/obdclass/obdo.c
[]
> @@ -161,35 +161,35 @@ int obdo_cmp_md(struct obdo *dst, struct obdo *src, u32 compare)
> {
> int res = 0;
>
> - if ( compare & OBD_MD_FLATIME )
> + if (compare & OBD_MD_FLATIME)
> res = (res || (dst->o_atime != src->o_atime));
These would be nicer as
res |= dst->o_atime != src->o_atime;
> - if ( compare & OBD_MD_FLMTIME )
> + if (compare & OBD_MD_FLMTIME)
> res = (res || (dst->o_mtime != src->o_mtime));
etc...
next prev parent reply other threads:[~2014-09-08 22:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-08 22:32 [PATCH] drivers: staging: lustre: Fix "space prohibited after that open parenthesis '('" errors Greg Donald
2014-09-08 22:38 ` Joe Perches [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-09-02 21:14 Greg Donald
2014-09-08 19:35 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1410215881.12560.21.camel@joe-AO725 \
--to=joe@perches.com \
--cc=andreas.dilger@intel.com \
--cc=gdonald@gmail.com \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg.drokin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.