From: Dmitry Voytik <voytikd@gmail.com>
To: Alexander Viro <viro@zeniv.linux.org.uk>
Cc: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
Dmitry Voytik <voytikd@gmail.com>
Subject: [PATCH] fs: seq_file: optimize seq_pad()
Date: Wed, 10 Sep 2014 13:20:19 +0400 [thread overview]
Message-ID: <1410340819-18338-1-git-send-email-voytikd@gmail.com> (raw)
Use seq_putc() instead of seq_printf() in seq_pad() because the
former is faster.
Signed-off-by: Dmitry Voytik <voytikd@gmail.com>
---
fs/seq_file.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/fs/seq_file.c b/fs/seq_file.c
index 3857b72..fef338e 100644
--- a/fs/seq_file.c
+++ b/fs/seq_file.c
@@ -787,8 +787,10 @@ EXPORT_SYMBOL(seq_write);
void seq_pad(struct seq_file *m, char c)
{
int size = m->pad_until - m->count;
- if (size > 0)
- seq_printf(m, "%*s", size, "");
+
+ while (size-- > 0)
+ if (unlikely(seq_putc(m, ' ')))
+ return;
if (c)
seq_putc(m, c);
}
--
1.9.1
next reply other threads:[~2014-09-10 9:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-10 9:20 Dmitry Voytik [this message]
2014-09-10 13:21 ` [PATCH] fs: seq_file: optimize seq_pad() Al Viro
2014-09-10 14:20 ` Dmitry Voytik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1410340819-18338-1-git-send-email-voytikd@gmail.com \
--to=voytikd@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.