From mboxrd@z Thu Jan 1 00:00:00 1970 From: Oliver Neukum Subject: Re: [PATCH 01/21] uas: replace WARN_ON_ONCE() with lockdep_assert_held() Date: Wed, 10 Sep 2014 14:54:23 +0200 Message-ID: <1410353663.12706.20.camel@linux-fkkt.site> References: <1410349611-17573-1-git-send-email-hdegoede@redhat.com> <1410349611-17573-2-git-send-email-hdegoede@redhat.com> <54103AA3.7000801@redhat.com> <1410350184.12706.18.camel@linux-fkkt.site> <54103D73.5050104@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <54103D73.5050104-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> Sender: linux-usb-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Hans de Goede Cc: Greg Kroah-Hartman , linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-scsi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Sanjeev Sharma List-Id: linux-scsi@vger.kernel.org On Wed, 2014-09-10 at 14:00 +0200, Hans de Goede wrote: > Hi, > > On 09/10/2014 01:56 PM, Oliver Neukum wrote: > > On Wed, 2014-09-10 at 13:48 +0200, Hans de Goede wrote: > >> Hi, > >> > >> Note this series is NOT intended for stable, but I accidentally > >> had "cc = stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" in my .git/config when sending > >> this series, please ignore for stable. > >> > >> NACK for stable. > > > > If this is not for stable, what do you intend to do about > > the problems in stable? For example patch#01 of this series > > looks like clear stable material to me. > > The plan for stable is mostly, as lame as that is, to make sure > we get all the right quirks in place so that error handling > does not get triggered, for now. How? A medium can be defect. Short of entirely disabling it, error handling will be triggered. > I agree that once this set has seen wider testing, we should > reconsider, and probably add it, to stable. But at this point > in time I'm worried that it may cause regressions, and as such > it is not stable material atm IHMO. Well, we would exchange something known to work imperfectly for something feared to work imperfectly. Regards Oliver -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html