All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gowtham Anandha Babu <gowtham.ab@samsung.com>
To: linux-bluetooth@vger.kernel.org
Cc: d.kasatkin@samsung.com, bharat.panda@samsung.com,
	cpgs@samsung.com, Gowtham Anandha Babu <gowtham.ab@samsung.com>
Subject: [PATCH 4/7] tools/csr_usb : Fix Resource leak: file
Date: Thu, 11 Sep 2014 18:50:04 +0530	[thread overview]
Message-ID: <1410441607-9687-4-git-send-email-gowtham.ab@samsung.com> (raw)
In-Reply-To: <1410441607-9687-1-git-send-email-gowtham.ab@samsung.com>

Handles resource leak.
---
 tools/csr_usb.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/tools/csr_usb.c b/tools/csr_usb.c
index 5fb6bdc..a1d7324 100644
--- a/tools/csr_usb.c
+++ b/tools/csr_usb.c
@@ -80,9 +80,12 @@ static int read_value(const char *name, const char *attr, const char *format)
 		return -1;
 
 	n = fscanf(file, format, &value);
-	if (n != 1)
+	if (n != 1) {
+		fclose(file);
 		return -1;
+	}
 
+	fclose(file);
 	return value;
 }
 
-- 
1.9.1


  parent reply	other threads:[~2014-09-11 13:20 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-11 13:20 [PATCH 1/7] obexd/client : Handle the MAP Extended Event Report 1.1 Gowtham Anandha Babu
2014-09-11 13:20 ` [PATCH 2/7] obexd/client/map : Handle MAP ReadStatusChanged event type Gowtham Anandha Babu
2014-09-11 21:00   ` Luiz Augusto von Dentz
2014-09-12 13:43     ` Gowtham Anandha Babu
2014-09-11 13:20 ` [PATCH 3/7] tools/btsnoop : Fix variable reassigning issue Gowtham Anandha Babu
2014-09-11 13:20 ` Gowtham Anandha Babu [this message]
2014-09-11 13:20 ` [PATCH 5/7] tools/seq2bseq : Fix the same expression issue in if condition Gowtham Anandha Babu
2014-09-11 13:20 ` [PATCH 6/7] tools/hciattach : Fix syntax error Gowtham Anandha Babu
2014-09-11 13:20 ` [PATCH 7/7] android/hal-utils.c : Fix null pointer dereference Gowtham Anandha Babu
2014-09-19  7:08   ` Szymon Janc
2014-09-11 16:37 ` [PATCH 1/7] obexd/client : Handle the MAP Extended Event Report 1.1 Johan Hedberg
2014-09-11 20:45   ` Luiz Augusto von Dentz
2014-09-12 13:49     ` Gowtham Anandha Babu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1410441607-9687-4-git-send-email-gowtham.ab@samsung.com \
    --to=gowtham.ab@samsung.com \
    --cc=bharat.panda@samsung.com \
    --cc=cpgs@samsung.com \
    --cc=d.kasatkin@samsung.com \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.