From: Jarkko Oranen <oranenj@iki.fi>
To: LVM general discussion and development <linux-lvm@redhat.com>
Cc: oranenj+lvm@iki.fi
Subject: Re: [linux-lvm] Does LVM RAID1 have TRIM support?
Date: Fri, 12 Sep 2014 10:24:41 +0300 [thread overview]
Message-ID: <1410506681.13625.60.camel@kurenai.local> (raw)
In-Reply-To: <47B3B0F3-0BC9-41D9-AB5C-FC1027E7B00F@redhat.com>
On Thu, 2014-09-11 at 18:31 -0500, Brassow Jonathan wrote:
> dm-raid.c does not have that - dm-raid1.c does. dm-raid1.c is a mirroring implementation specific to device-mapper. It is used by LVM for pvmove functionality (and is otherwise being slowly phased out). dm-raid.c is the device-mapper wrapper around the MD RAID personalities. It does not have discard support.
>
> I will ask Neil what the current state of discard support is in MD. I see that "support" was added in Oct of 2012 (starting at commit 2ff8cc2), but I remember them having problems with discards + any resync operations. If Neil says it is ok, I will turn it on.
>
In the code that I'm looking at dm-raid.c definitely sets
num_discard_bios to 1 on something... As does dm-raid1.c. However,
Thanks for looking into it!
> brassow
>
> _______________________________________________
> linux-lvm mailing list
> linux-lvm@redhat.com
> https://www.redhat.com/mailman/listinfo/linux-lvm
> read the LVM HOW-TO at http://tldp.org/HOWTO/LVM-HOWTO/
next prev parent reply other threads:[~2014-09-12 7:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-24 16:08 [linux-lvm] Does LVM RAID1 have TRIM support? Jarkko Oranen
2014-09-02 21:49 ` Brassow Jonathan
2014-09-04 11:06 ` Jarkko Oranen
2014-09-08 17:47 ` Brassow Jonathan
2014-09-08 18:47 ` Jarkko Oranen
2014-09-11 23:31 ` Brassow Jonathan
2014-09-12 7:24 ` Jarkko Oranen [this message]
2014-09-24 4:17 ` Brassow Jonathan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1410506681.13625.60.camel@kurenai.local \
--to=oranenj@iki.fi \
--cc=linux-lvm@redhat.com \
--cc=oranenj+lvm@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.