From: Sedat Dilek <sedat.dilek@gmail.com>
To: intel-gfx <intel-gfx@lists.freedesktop.org>,
Chris Wilson <chris@chris-wilson.co.uk>
Cc: Sedat Dilek <sedat.dilek@gmail.com>
Subject: [PATCH] uxa: intel_sync_close() is only available when HAVE_DRI3
Date: Sat, 13 Sep 2014 19:45:01 +0200 [thread overview]
Message-ID: <1410630301-14108-1-git-send-email-sedat.dilek@gmail.com> (raw)
With LLVM v3.4.2 I got this error reported:
...
intel_driver.c:1182:2: error: implicit declaration of function 'intel_sync_close' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
intel_sync_close(screen);
^
In file included from intel_uxa.c:44:
./intel_glamor.h:92:1: warning: unused function 'intel_glamor_fd_from_pixmap' [-Wunused-function]
intel_glamor_fd_from_pixmap(ScreenPtr screen,
^
intel_driver.c:1182:2: note: did you mean 'intel_mode_close'?
./intel.h:356:13: note: 'intel_mode_close' declared here
extern void intel_mode_close(intel_screen_private *intel);
...
Looking at <uxa/intel.h> intel_sync_close() is only available when DRI3 is supported.
516: #if HAVE_DRI3
517: Bool intel_sync_init(ScreenPtr screen);
518: void intel_sync_close(ScreenPtr screen);
519: #endif
Fix the issue by embedding intel_sync_close() with a HAVE_DRI3 ifdef check.
Signed-off-by: Sedat Dilek <sedat.dilek@gmail.com>
---
src/uxa/intel_driver.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/uxa/intel_driver.c b/src/uxa/intel_driver.c
index f31f7bd..9f527fd 100644
--- a/src/uxa/intel_driver.c
+++ b/src/uxa/intel_driver.c
@@ -1179,7 +1179,9 @@ static Bool I830CloseScreen(CLOSE_SCREEN_ARGS_DECL)
intel->dri3 = DRI_NONE;
}
+#if HAVE_DRI3
intel_sync_close(screen);
+#endif
xf86GARTCloseScreen(scrn->scrnIndex);
--
2.1.0
next reply other threads:[~2014-09-13 17:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-13 17:45 Sedat Dilek [this message]
2014-09-15 7:58 ` [PATCH] uxa: intel_sync_close() is only available when HAVE_DRI3 Chris Wilson
2014-09-15 11:12 ` Sedat Dilek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1410630301-14108-1-git-send-email-sedat.dilek@gmail.com \
--to=sedat.dilek@gmail.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.