From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753313AbaIPHqW (ORCPT ); Tue, 16 Sep 2014 03:46:22 -0400 Received: from mga14.intel.com ([192.55.52.115]:26674 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752772AbaIPHqU (ORCPT ); Tue, 16 Sep 2014 03:46:20 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.04,533,1406617200"; d="scan'208";a="591873781" Message-ID: <1410853522.1280.0.camel@rzhang1-toshiba> Subject: Re: [PATCH v4 2/4] dt-bindings: document Rockchip thermal From: Zhang Rui To: Eduardo Valentin Cc: Arnd Bergmann , Heiko =?ISO-8859-1?Q?St=FCbner?= , Caesar Wang , LKML , "linux-pm@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "devicetree@vger.kernel.org" , "linux-doc@vger.kernel.org" , Tao Huang , Eddie Cai , Douglas Anderson , dtor , Chris Zhong , "addy.ke@rock-chips.com" , Dmitry Torokhov , zhaoyifeng Date: Tue, 16 Sep 2014 15:45:22 +0800 In-Reply-To: <20140911155324.GA27076@developer> References: <1409710239-19941-1-git-send-email-caesar.wang@rock-chips.com> <1410403012.25559.69.camel@rzhang1-toshiba> <20140911121842.GB26715@developer> <40514790.Xc34lyFLGa@wuerfel> <20140911155324.GA27076@developer> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.8.4-0ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2014-09-11 at 11:53 -0400, Eduardo Valentin wrote: > Arnd, > > On Thu, Sep 11, 2014 at 02:32:08PM +0200, Arnd Bergmann wrote: > > On Thursday 11 September 2014 08:18:43 Eduardo Valentin wrote: > > > > As what we want is to make thermal driver have a chance to configure the > > > > hardware shutdown registers, I'm thinking if we can do this without > > > > representing the hardware shutdown value as a trip point. > > > > Say, > > > > 1. parse DT, and get the hardware shutdown temperature value, and store > > > > it somewhere, e.g. struct __thermal_zone. > > > > 2. introduce a new parameter, int (*set_hardware_trip)(void *, long *), > > > > in thermal_zone_of_sensor_register(). > > > > 3. invoke set_hard_trip(tz, hardware_shutdown_temperature_value) in > > > > thermal_zone_of_sensor_register(). > > > > > > The only issue I have with the above proposal is that not all platforms > > > use DT. Some still boot with boardfiles, for instance. Thus, the > > > parameter to configure hardware thermal shutdown needs to be common on > > > thermal core, not specific to of-thermal. Do you agree? > > > > Do you know of a machine that can't yet be converted to DT and that > > needs this driver? In case of rockchips that is certainly not the > > case, and we don't care about anybody trying to use board files out > > of tree, they can just hack the thermal support as well. > > I see. Again, the only concern I have is to produce thermal framework APIs > that would be only in the of-thermal. My point is not specific to this > patch, or this platform, but with a detail in the above proposal. > > While I agree to have a trip specific to configurable hardware triggered > thermal shutdown, I just don't see why it needs to be a feature > implemented only via of-thermal. It has to be properly defined in > thermal core. > > The proposal of of-thermal is not to become a separate/competing thermal > framework. > Agreed. And I think we can have such feature in thermal core. But again I don't think we should represent it as an trip point. Instead, we can have a separate parameter for thanks, rui > > > > Arnd > > Cheers, > > Eduardo From mboxrd@z Thu Jan 1 00:00:00 1970 From: rui.zhang@intel.com (Zhang Rui) Date: Tue, 16 Sep 2014 15:45:22 +0800 Subject: [PATCH v4 2/4] dt-bindings: document Rockchip thermal In-Reply-To: <20140911155324.GA27076@developer> References: <1409710239-19941-1-git-send-email-caesar.wang@rock-chips.com> <1410403012.25559.69.camel@rzhang1-toshiba> <20140911121842.GB26715@developer> <40514790.Xc34lyFLGa@wuerfel> <20140911155324.GA27076@developer> Message-ID: <1410853522.1280.0.camel@rzhang1-toshiba> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, 2014-09-11 at 11:53 -0400, Eduardo Valentin wrote: > Arnd, > > On Thu, Sep 11, 2014 at 02:32:08PM +0200, Arnd Bergmann wrote: > > On Thursday 11 September 2014 08:18:43 Eduardo Valentin wrote: > > > > As what we want is to make thermal driver have a chance to configure the > > > > hardware shutdown registers, I'm thinking if we can do this without > > > > representing the hardware shutdown value as a trip point. > > > > Say, > > > > 1. parse DT, and get the hardware shutdown temperature value, and store > > > > it somewhere, e.g. struct __thermal_zone. > > > > 2. introduce a new parameter, int (*set_hardware_trip)(void *, long *), > > > > in thermal_zone_of_sensor_register(). > > > > 3. invoke set_hard_trip(tz, hardware_shutdown_temperature_value) in > > > > thermal_zone_of_sensor_register(). > > > > > > The only issue I have with the above proposal is that not all platforms > > > use DT. Some still boot with boardfiles, for instance. Thus, the > > > parameter to configure hardware thermal shutdown needs to be common on > > > thermal core, not specific to of-thermal. Do you agree? > > > > Do you know of a machine that can't yet be converted to DT and that > > needs this driver? In case of rockchips that is certainly not the > > case, and we don't care about anybody trying to use board files out > > of tree, they can just hack the thermal support as well. > > I see. Again, the only concern I have is to produce thermal framework APIs > that would be only in the of-thermal. My point is not specific to this > patch, or this platform, but with a detail in the above proposal. > > While I agree to have a trip specific to configurable hardware triggered > thermal shutdown, I just don't see why it needs to be a feature > implemented only via of-thermal. It has to be properly defined in > thermal core. > > The proposal of of-thermal is not to become a separate/competing thermal > framework. > Agreed. And I think we can have such feature in thermal core. But again I don't think we should represent it as an trip point. Instead, we can have a separate parameter for thanks, rui > > > > Arnd > > Cheers, > > Eduardo