All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Herbrechtsmeier <stefan@herbrechtsmeier.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/5] omap3: overo: Fix fdtfile test
Date: Tue, 16 Sep 2014 17:51:05 +0200	[thread overview]
Message-ID: <1410882669-705-2-git-send-email-stefan@herbrechtsmeier.net> (raw)
In-Reply-To: <1410882669-705-1-git-send-email-stefan@herbrechtsmeier.net>

Commit 12cc54376768461533b55ada1b0b6d4979f40579 'omap3: overo: Select
fdtfile for expansion board' wrongly missed the operator in the fdtfile
test. Update the test to only overwrite an empty fdtfile environment
variable.

Signed-off-by: Stefan Herbrechtsmeier <stefan@herbrechtsmeier.net>
---

 include/configs/omap3_overo.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/configs/omap3_overo.h b/include/configs/omap3_overo.h
index e66f306..b17e495 100644
--- a/include/configs/omap3_overo.h
+++ b/include/configs/omap3_overo.h
@@ -151,7 +151,7 @@
 			"run mmcboot;" \
 		"fi;" \
 		"if run loadzimage; then " \
-			"if test $fdtfile; then " \
+			"if test -z \"${fdtfile}\"; then " \
 				"setenv fdtfile omap3-${boardname}-${expansionname}.dtb;" \
 			"fi;" \
 			"if run loadfdt; then " \
-- 
2.1.0

  reply	other threads:[~2014-09-16 15:51 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-16 15:51 [U-Boot] [PATCH 0/5] omap3: overo: Add foreign expansion board support Stefan Herbrechtsmeier
2014-09-16 15:51 ` Stefan Herbrechtsmeier [this message]
2014-10-10 14:39   ` [U-Boot] [U-Boot,1/5] omap3: overo: Fix fdtfile test Tom Rini
2014-09-16 15:51 ` [U-Boot] [PATCH 2/5] omap3: overo: Call bootm only after successful nand read Stefan Herbrechtsmeier
2014-10-23 17:16   ` [U-Boot] [U-Boot, " Tom Rini
2014-09-16 15:51 ` [U-Boot] [PATCH 3/5] omap3: overo: Move ethernet setup to board_eth_init function Stefan Herbrechtsmeier
2014-10-23 17:16   ` [U-Boot] [U-Boot, " Tom Rini
2014-09-16 15:51 ` [U-Boot] [PATCH 4/5] omap3: overo: Separate module and expansion board MUX configuration Stefan Herbrechtsmeier
2014-10-23 17:16   ` [U-Boot] [U-Boot, " Tom Rini
2014-09-16 15:51 ` [U-Boot] [PATCH 5/5] omap3: overo: Add usb host support Stefan Herbrechtsmeier
2014-10-23 17:16   ` [U-Boot] [U-Boot,5/5] " Tom Rini
2014-09-30  5:10 ` [U-Boot] [PATCH 0/5] omap3: overo: Add foreign expansion board support Stefan Herbrechtsmeier
2014-10-10 16:12 ` Tom Rini
2014-10-10 16:13   ` Ash Charles

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1410882669-705-2-git-send-email-stefan@herbrechtsmeier.net \
    --to=stefan@herbrechtsmeier.net \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.