From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH] clang: sizeof(type) must not have __attribute__(aligned) Date: Tue, 16 Sep 2014 17:21:26 +0100 Message-ID: <1410884486.23505.1.camel@citrix.com> References: <533464AA.8080807@linaro.org> <1410633772-23044-1-git-send-email-saper@saper.info> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta4.messagelabs.com ([85.158.143.247]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1XTvVU-0004AW-IC for xen-devel@lists.xenproject.org; Tue, 16 Sep 2014 16:21:32 +0000 In-Reply-To: <1410633772-23044-1-git-send-email-saper@saper.info> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Marcin Cieslak Cc: xen-devel@lists.xenproject.org, julien.grall@linaro.org List-Id: xen-devel@lists.xenproject.org On Sat, 2014-09-13 at 18:42 +0000, Marcin Cieslak wrote: The commit message could go into a bit more detail as to why this is not allowed. To me it sounds like clang is being overly picky, surely it can just ignore the alignment in that context? > +typesizes["arm32"] = { Duplicating the entire inttypes list is not really very nice. I would prefer instead to make the existing inttypes more structured and separate the type itself and the other modifiers/attributes into fields (of a class or in a tuple) and put them together in the right way as we need them. Methods on the class or helpers (type.gen_type() gen_sizeof() etc) would help keep this clean. Ian.