From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH v4 for 4.5 4/8] libxl: refactor
	libxl_get_memory_target
Date: Tue, 16 Sep 2014 20:02:38 +0100
Message-ID: <1410894158.23505.30.camel@citrix.com>
References: <1410861678-31428-1-git-send-email-wei.liu2@citrix.com>
	<1410861678-31428-5-git-send-email-wei.liu2@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1410861678-31428-5-git-send-email-wei.liu2@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Wei Liu <wei.liu2@citrix.com>
Cc: ian.jackson@eu.citrix.com, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On Tue, 2014-09-16 at 11:01 +0100, Wei Liu wrote:
> -static int libxl__fill_dom0_memory_info(libxl__gc *gc, uint32_t *target_memkb)
> +static int libxl__fill_dom0_memory_info(libxl__gc *gc, uint32_t *target_memkb,
> +                                        uint32_t *max_memkb)

Looking at the callers I think you could have made this tolerate NULL
too, since the callers don't all need both AFAICT. But regardless:

Acked-by: Ian Campbell <ian.campbell@citrix.com>