From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rodrigo Vivi Subject: [PATCH 4/5] drm/i915: Let number of workarounds more clear Date: Fri, 19 Sep 2014 20:16:29 -0400 Message-ID: <1411172190-1642-4-git-send-email-rodrigo.vivi@intel.com> References: <1411172190-1642-1-git-send-email-rodrigo.vivi@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTP id 777656E711 for ; Fri, 19 Sep 2014 17:18:24 -0700 (PDT) In-Reply-To: <1411172190-1642-1-git-send-email-rodrigo.vivi@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: intel-gfx@lists.freedesktop.org Cc: Rodrigo Vivi List-Id: intel-gfx@lists.freedesktop.org This helps when including or removing cs workarounds. Signed-off-by: Rodrigo Vivi --- drivers/gpu/drm/i915/intel_ringbuffer.c | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.c b/drivers/gpu/drm/i915/intel_ringbuffer.c index 7c3d17a..39fbea6 100644 --- a/drivers/gpu/drm/i915/intel_ringbuffer.c +++ b/drivers/gpu/drm/i915/intel_ringbuffer.c @@ -694,6 +694,7 @@ static int bdw_init_workarounds(struct intel_engine_cs *ring) int ret; struct drm_device *dev = ring->dev; struct drm_i915_private *dev_priv = dev->dev_private; + int wa_amount; /* * workarounds applied in this fn are part of register state context, @@ -704,10 +705,11 @@ static int bdw_init_workarounds(struct intel_engine_cs *ring) memset(dev_priv->intel_wa_regs, 0, sizeof(dev_priv->intel_wa_regs)); /* - * update the number of dwords required based on the - * actual number of workarounds applied + * update the number of workarounds when adding or removing was + * in order the have propper dwords */ - ret = intel_ring_begin(ring, 24); + wa_amount = 8; + ret = intel_ring_begin(ring, 3 * wa_amount); if (ret) return ret; @@ -775,6 +777,7 @@ static int chv_init_workarounds(struct intel_engine_cs *ring) int ret; struct drm_device *dev = ring->dev; struct drm_i915_private *dev_priv = dev->dev_private; + int wa_amount; /* * workarounds applied in this fn are part of register state context, @@ -784,7 +787,12 @@ static int chv_init_workarounds(struct intel_engine_cs *ring) dev_priv->num_wa_regs = 0; memset(dev_priv->intel_wa_regs, 0, sizeof(dev_priv->intel_wa_regs)); - ret = intel_ring_begin(ring, 12); + /* + * update the number of workarounds when adding or removing was + * in order the have propper dwords + */ + wa_amount = 4; + ret = intel_ring_begin(ring, 3 * wa_amount); if (ret) return ret; -- 1.9.3