From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58052) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XWPqJ-0000tr-Go for qemu-devel@nongnu.org; Tue, 23 Sep 2014 09:09:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XWPqC-0002bh-S4 for qemu-devel@nongnu.org; Tue, 23 Sep 2014 09:09:19 -0400 Received: from szxga03-in.huawei.com ([119.145.14.66]:49743) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XWPqC-0002ae-4q for qemu-devel@nongnu.org; Tue, 23 Sep 2014 09:09:12 -0400 From: Date: Tue, 23 Sep 2014 21:08:37 +0800 Message-ID: <1411477717-6988-8-git-send-email-arei.gonglei@huawei.com> In-Reply-To: <1411477717-6988-1-git-send-email-arei.gonglei@huawei.com> References: <1411477717-6988-1-git-send-email-arei.gonglei@huawei.com> MIME-Version: 1.0 Content-Type: text/plain Subject: [Qemu-devel] [PATCH 7/7] qdev: drop legacy_name from qdev properties List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: weidong.huang@huawei.com, aliguori@amazon.com, mst@redhat.com, armbru@redhat.com, luonengjun@huawei.com, peter.huangpeng@huawei.com, lcapitulino@redhat.com, Gonglei , stefanha@redhat.com, pbonzini@redhat.com, afaerber@suse.de From: Gonglei The legacy_name is useless now, the better help information provied by description field of property. Cc: Paolo Bonzini Cc: Michael S. Tsirkin Cc: Markus Armbruster Signed-off-by: Gonglei --- hw/core/qdev-properties-system.c | 4 ---- hw/core/qdev-properties.c | 6 ------ include/hw/qdev-core.h | 1 - target-ppc/translate_init.c | 1 - 4 files changed, 12 deletions(-) diff --git a/hw/core/qdev-properties-system.c b/hw/core/qdev-properties-system.c index 4c8ea18..15b6567 100644 --- a/hw/core/qdev-properties-system.c +++ b/hw/core/qdev-properties-system.c @@ -112,7 +112,6 @@ static void set_drive(Object *obj, Visitor *v, void *opaque, PropertyInfo qdev_prop_drive = { .name = "str", - .legacy_name = "drive", .description = "ID of a drive to use as a backend", .get = get_drive, .set = set_drive, @@ -170,7 +169,6 @@ static void set_chr(Object *obj, Visitor *v, void *opaque, PropertyInfo qdev_prop_chr = { .name = "str", - .legacy_name = "chr", .description = "ID of a chardev to use as a backend", .get = get_chr, .set = set_chr, @@ -250,7 +248,6 @@ static void set_netdev(Object *obj, Visitor *v, void *opaque, PropertyInfo qdev_prop_netdev = { .name = "str", - .legacy_name = "netdev", .description = "ID of a netdev to use as a backend", .get = get_netdev, .set = set_netdev, @@ -331,7 +328,6 @@ static void set_vlan(Object *obj, Visitor *v, void *opaque, PropertyInfo qdev_prop_vlan = { .name = "int32", - .legacy_name = "vlan", .description = "The value of vlan id", .print = print_vlan, .get = get_vlan, diff --git a/hw/core/qdev-properties.c b/hw/core/qdev-properties.c index 2f7e52b..a593950 100644 --- a/hw/core/qdev-properties.c +++ b/hw/core/qdev-properties.c @@ -120,7 +120,6 @@ static void prop_set_bit(Object *obj, Visitor *v, void *opaque, PropertyInfo qdev_prop_bit = { .name = "bool", - .legacy_name = "on/off", .description = "on/off", .get = prop_get_bit, .set = prop_set_bit, @@ -456,7 +455,6 @@ inval: PropertyInfo qdev_prop_macaddr = { .name = "str", - .legacy_name = "macaddr", .description = "Ethernet 6-byte MAC Address, format: AA:BB:CC:DD:EE:FF", .get = get_mac, .set = set_mac, @@ -479,7 +477,6 @@ QEMU_BUILD_BUG_ON(sizeof(BiosAtaTranslation) != sizeof(int)); PropertyInfo qdev_prop_bios_chs_trans = { .name = "BiosAtaTranslation", - .legacy_name = "bios-chs-trans", .description = "Bios ata translation", .enum_table = BiosAtaTranslation_lookup, .get = get_enum, @@ -554,7 +551,6 @@ static int print_pci_devfn(DeviceState *dev, Property *prop, char *dest, PropertyInfo qdev_prop_pci_devfn = { .name = "int32", - .legacy_name = "pci-devfn", .description = "The slot number of a pci device", .print = print_pci_devfn, .get = get_int32, @@ -602,7 +598,6 @@ static void set_blocksize(Object *obj, Visitor *v, void *opaque, PropertyInfo qdev_prop_blocksize = { .name = "uint16", - .legacy_name = "blocksize", .description = "A power of two between 512 and 32768", .get = get_uint16, .set = set_blocksize, @@ -711,7 +706,6 @@ inval: PropertyInfo qdev_prop_pci_host_devaddr = { .name = "str", - .legacy_name = "pci-host-devaddr", .description = "The bdf number of pci on host, such as: 04:10.0", .get = get_pci_host_devaddr, .set = set_pci_host_devaddr, diff --git a/include/hw/qdev-core.h b/include/hw/qdev-core.h index 31acbe6..7fcd415 100644 --- a/include/hw/qdev-core.h +++ b/include/hw/qdev-core.h @@ -232,7 +232,6 @@ struct Property { struct PropertyInfo { const char *name; - const char *legacy_name; const char *description; const char **enum_table; int (*print)(DeviceState *dev, Property *prop, char *dest, size_t len); diff --git a/target-ppc/translate_init.c b/target-ppc/translate_init.c index 56a9f75..35e4ee4 100644 --- a/target-ppc/translate_init.c +++ b/target-ppc/translate_init.c @@ -8044,7 +8044,6 @@ static void powerpc_set_compat(Object *obj, Visitor *v, static PropertyInfo powerpc_compat_propinfo = { .name = "str", - .legacy_name = "powerpc-server-compat", .description = "PowerPC server compat", .get = powerpc_get_compat, .set = powerpc_set_compat, -- 1.7.12.4