From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tamas K Lengyel Subject: [PATCH for-4.5 v8 09/19] xen/mem_event: Relax error condition on debug builds Date: Tue, 23 Sep 2014 15:14:20 +0200 Message-ID: <1411478070-13836-10-git-send-email-tklengyel@sec.in.tum.de> References: <1411478070-13836-1-git-send-email-tklengyel@sec.in.tum.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1411478070-13836-1-git-send-email-tklengyel@sec.in.tum.de> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: xen-devel@lists.xen.org Cc: ian.campbell@citrix.com, tim@xen.org, julien.grall@linaro.org, ian.jackson@eu.citrix.com, stefano.stabellini@citrix.com, andres@lagarcavilla.org, jbeulich@suse.com, dgdegra@tycho.nsa.gov, Tamas K Lengyel List-Id: xen-devel@lists.xenproject.org A faulty tool stack can brick a debug hypervisor. Unpleasant while dev/test. Suggested-by: Andres Lagar Cavilla Signed-off-by: Tamas K Lengyel Acked-by: Tim Deegan --- v5: Make printout greppable. v4: Add domain_id to the printout. v3: Switch to gdprintk and print the vCPU id as well. --- xen/common/mem_event.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/xen/common/mem_event.c b/xen/common/mem_event.c index 638b4e3..c04a685 100644 --- a/xen/common/mem_event.c +++ b/xen/common/mem_event.c @@ -285,7 +285,11 @@ void mem_event_put_request(struct domain *d, if ( current->domain != d ) { req->flags |= MEM_EVENT_FLAG_FOREIGN; - ASSERT( !(req->flags & MEM_EVENT_FLAG_VCPU_PAUSED) ); +#ifndef NDEBUG + if ( !(req->flags & MEM_EVENT_FLAG_VCPU_PAUSED) ) + gdprintk(XENLOG_G_WARNING, "d%dv%d was not paused.\n", + d->domain_id, req->vcpu_id); +#endif } mem_event_ring_lock(med); -- 2.1.0