All of lore.kernel.org
 help / color / mirror / Atom feed
From: behanw@converseincode.com
To: bcm@fixthebug.org, chris@printf.net, gnurou@gmail.com,
	linus.walleij@linaro.org, mporter@linaro.org,
	ulf.hansson@linaro.org
Cc: bcm-kernel-feedback-list@broadcom.com,
	linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-mmc@vger.kernel.org, rjui@broadcom.com,
	Behan Webster <behanw@converseincode.com>
Subject: [PATCH v2 2/2] mmc, sdhci, bcm-kona, LLVMLinux: Remove use of __initconst
Date: Tue, 23 Sep 2014 15:55:08 -0700	[thread overview]
Message-ID: <1411512908-19237-2-git-send-email-behanw@converseincode.com> (raw)
In-Reply-To: <1411512908-19237-1-git-send-email-behanw@converseincode.com>

From: Behan Webster <behanw@converseincode.com>

The __initconst is in the wrong place, and when moved to the correct place
it uncovers an error where the variable is used by non-init data structures.

Instead merely make them const and put the const in the right spot.

Signed-off-by: Behan Webster <behanw@converseincode.com>
Reviewed-by: Mark Charlebois <charlebm@gmail.com>
Acked-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Matt Porter <mporter@linaro.org>
---
 drivers/mmc/host/sdhci-bcm-kona.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mmc/host/sdhci-bcm-kona.c b/drivers/mmc/host/sdhci-bcm-kona.c
index dd780c3..4bb06c8 100644
--- a/drivers/mmc/host/sdhci-bcm-kona.c
+++ b/drivers/mmc/host/sdhci-bcm-kona.c
@@ -225,7 +225,7 @@ static struct sdhci_pltfm_data sdhci_pltfm_data_kona = {
 		SDHCI_QUIRK_CAP_CLOCK_BASE_BROKEN,
 };
 
-static struct __initconst of_device_id sdhci_bcm_kona_of_match[] = {
+static struct of_device_id const sdhci_bcm_kona_of_match[] = {
 	{ .compatible = "brcm,kona-sdhci"},
 	{ .compatible = "bcm,kona-sdhci"}, /* deprecated name */
 	{}
-- 
1.9.1


  reply	other threads:[~2014-09-23 22:55 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-23 19:30 [PATCH] gpio, bcm-kona, LLVMLinux: Remove use of __initconst behanw
2014-09-23 21:20 ` Matt Porter
2014-09-23 21:29 ` Matt Porter
2014-09-23 22:55   ` [PATCH v2 1/2] " behanw
2014-09-23 22:55     ` behanw [this message]
2014-09-24  9:22       ` [PATCH v2 2/2] mmc, sdhci, " Arnd Bergmann
2014-09-24 18:21         ` Behan Webster
2014-09-24 18:21           ` Behan Webster
2014-09-25  8:18           ` Linus Walleij
2014-09-25 22:45         ` [PATCH v3] " Behan Webster
2014-10-03 12:59           ` Ulf Hansson
2014-09-24 11:40     ` [PATCH v2 1/2] gpio, " Linus Walleij
2014-09-23 22:59   ` [PATCH] " Behan Webster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1411512908-19237-2-git-send-email-behanw@converseincode.com \
    --to=behanw@converseincode.com \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=bcm@fixthebug.org \
    --cc=chris@printf.net \
    --cc=gnurou@gmail.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=mporter@linaro.org \
    --cc=rjui@broadcom.com \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.