From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH for-4.5 v8 19/19] tools/tests: Enable xen-access on ARM Date: Wed, 24 Sep 2014 16:12:13 +0100 Message-ID: <1411571533.28127.67.camel@kazak.uk.xensource.com> References: <1411478070-13836-1-git-send-email-tklengyel@sec.in.tum.de> <1411478070-13836-20-git-send-email-tklengyel@sec.in.tum.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1411478070-13836-20-git-send-email-tklengyel@sec.in.tum.de> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Tamas K Lengyel Cc: tim@xen.org, julien.grall@linaro.org, ian.jackson@eu.citrix.com, xen-devel@lists.xen.org, stefano.stabellini@citrix.com, andres@lagarcavilla.org, jbeulich@suse.com, dgdegra@tycho.nsa.gov List-Id: xen-devel@lists.xenproject.org On Tue, 2014-09-23 at 15:14 +0200, Tamas K Lengyel wrote: > Define the ARM specific test_and_set_bit functions and switch > to use maximum gpfn as the limit to setting permissions. Also, > move HAS_MEM_ACCESS definition into config. Please could you mention the removal of the x86 comment about atomicity here, since the reasoning for its correctness will be of interest to future code archaeologists. > - rc = xc_set_mem_access(xch, domain_id, default_access, 0, > - xenaccess->domain_info->max_pages); > + rc = xc_set_mem_access(xch, domain_id, default_access, START_PFN, > + (xenaccess->max_gpfn - START_PFN) ); So the reason why info->max_pages is no use any more is because ARM starts at non-zero and has multiple banks? I suppose that's fair enough. Ian.