All of lore.kernel.org
 help / color / mirror / Atom feed
From: Scott Wood <scottwood@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v10] nand/denali: Adding Denali NAND driver support
Date: Wed, 24 Sep 2014 18:34:52 -0500	[thread overview]
Message-ID: <1411601692.13320.176.camel@snotra.buserror.net> (raw)
In-Reply-To: <CAMhH57T=XOHVG2UnOpPwRHiekbgU8PVYimz2xM_QaaH0_bP2ow@mail.gmail.com>

On Wed, 2014-09-24 at 23:05 +0900, Masahiro YAMADA wrote:
> Hi Scott, Tom,
> 
> 
> 2014-09-12 19:43 GMT+09:00 Masahiro Yamada <yamada.m@jp.panasonic.com>:
> >
> > On Fri, 12 Sep 2014 00:42:17 -0500
> > Chin Liang See <clsee@altera.com> wrote:
> >
> >> To add the Denali NAND driver support into U-Boot.
> >> This driver is leveraged from Linux with commit ID
> >> fdbad98dff8007f2b8bee6698b5d25ebba0471c9. For Denali
> >> controller 64 variance, you need to declare macro
> >> CONFIG_SYS_NAND_DENALI_64BIT.
> >>
> >> Signed-off-by: Chin Liang See <clsee@altera.com>
> >> Cc: Scott Wood <scottwood@freescale.com>
> >> Cc: Masahiro Yamada <yamada.m@jp.panasonic.com>
> >> ---
> >> Changes for v10
> >> - Updated the commit message to include Linux driver commit ID,
> >> usage of macro CONFIG_SYS_NAND_DENALI_64BIT
> >> - Removed casting for memcpy function
> >> - Removed NAND_CMD_LOCK_TIGHT support as no longer in latest NAND driver
> >
> >
> > Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
> > Reviewed-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
> > Tested-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
> >
> >
> > I am looking forward to get this driver in.
> >
> 
> 
> How about this patch?
> 
> 
> There are only some cosmetic updates in v10.
> I think enough time has passed for the review.
> 
> If Scott could apply it, that would be the best,
> but he seems really busy for Linux work these days
> as he stated in http://lists.denx.de/pipermail/u-boot/2014-May/180399.html.
> 
> Tom,
> If Scott is too busy to take care of this patch,
> could you apply it directly onto u-boot/master, please?

How would I go about testing that this builds?  I don't see any code in
the tree that defines CONFIG_NAND_DENALI, nor is it obvious which board
I should add it to as a test.

Also, CONFIG_SYS_NAND_DENALI_64BIT should be documented in a README, not
just in the git changelog.

-Scott

  reply	other threads:[~2014-09-24 23:34 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-12  5:42 [U-Boot] [PATCH v10] nand/denali: Adding Denali NAND driver support Chin Liang See
2014-09-12 10:43 ` Masahiro Yamada
2014-09-24 14:05   ` Masahiro YAMADA
2014-09-24 23:34     ` Scott Wood [this message]
2014-09-25  7:36       ` Masahiro Yamada

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1411601692.13320.176.camel@snotra.buserror.net \
    --to=scottwood@freescale.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.