From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753310AbaIYN7M (ORCPT ); Thu, 25 Sep 2014 09:59:12 -0400 Received: from mail-la0-f44.google.com ([209.85.215.44]:60870 "EHLO mail-la0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751883AbaIYN7J (ORCPT ); Thu, 25 Sep 2014 09:59:09 -0400 Message-ID: <1411653544.15810.47.camel@marge.simpson.net> Subject: BUG: sleeping function called from invalid context at drivers/cpufreq/cpufreq.c:370 From: Mike Galbraith To: Peter Zijlstra Cc: mingo@kernel.org, oleg@redhat.com, torvalds@linux-foundation.org, tglx@linutronix.de, ilya.dryomov@inktank.com, linux-kernel@vger.kernel.org, "Rafael J. Wysocki" Date: Thu, 25 Sep 2014 15:59:04 +0200 In-Reply-To: <1411639019.15810.31.camel@marge.simpson.net> References: <20140924081845.572814794@infradead.org> <1411633803.15810.12.camel@marge.simpson.net> <20140925090619.GA5430@worktop> <20140925091556.GB5430@worktop> <1411639019.15810.31.camel@marge.simpson.net> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3 Content-Transfer-Encoding: 7bit Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2014-09-25 at 11:56 +0200, Mike Galbraith wrote: > On Thu, 2014-09-25 at 11:15 +0200, Peter Zijlstra wrote: > > > I suppose just flipping the scheudle() and try_to_freeze() should do the > > trick. Ugly code that, but then again, I think audit is known for that. > > > > Can you give that a go? > > Yeah, seems that fixed that one. pcc-cpufreq: spin_lock() -> wait_event() -> gripe() gripe() gripe()... [ 50.756280] BUG: sleeping function called from invalid context at drivers/cpufreq/cpufreq.c:370 [ 50.850582] in_atomic(): 1, irqs_disabled(): 0, pid: 2636, name: modprobe [ 50.926744] Preemption disabled at:[] pcc_cpufreq_target+0x27/0x200 [pcc_cpufreq] [ 51.025044] [ 51.045454] CPU: 57 PID: 2636 Comm: modprobe Tainted: G E 3.17.0-default #7 [ 51.136727] Hardware name: Hewlett-Packard ProLiant DL980 G7, BIOS P66 07/07/2010 [ 51.218484] 00000000ffffffff ffff88026c46b828 ffffffff81589dbd 0000000000000000 [ 51.300293] ffff880037978090 ffff88026c46b848 ffffffff8108e1df ffff880037978090 [ 51.382666] 0000000000000000 ffff88026c46b878 ffffffff8108e298 ffff88026d73ec00 [ 51.464884] Call Trace: [ 51.495159] [] dump_stack+0x4d/0x90 [ 51.555439] [] ___might_sleep+0x10f/0x180 [ 51.620610] [] __might_sleep+0x48/0xd0 [ 51.684774] [] cpufreq_freq_transition_begin+0x75/0x140 drivers/cpufreq/cpufreq.c:370 wait_event(policy->transition_wait, !policy->transition_ongoing); [ 51.767992] [] ? preempt_count_add+0xb9/0xc0 [ 51.833294] [] pcc_cpufreq_target+0x63/0x200 [pcc_cpufreq] drivers/cpufreq/pcc-cpufreq.c:207 spin_lock(&pcc_lock); [ 51.930204] [] ? update_ts_time_stats+0x7f/0xb0 [ 52.009288] [] __cpufreq_driver_target+0x85/0x170 [ 52.082479] [] od_check_cpu+0xa8/0xb0 [ 52.143874] [] dbs_check_cpu+0x180/0x1d0 [ 52.207329] [] cpufreq_governor_dbs+0x3b0/0x720 [ 52.276916] [] od_cpufreq_governor_dbs+0x33/0xe0 [ 52.349048] [] __cpufreq_governor+0xa9/0x210 [ 52.415040] [] cpufreq_set_policy+0x1e2/0x2e0 [ 52.480473] [] cpufreq_init_policy+0x8c/0x110 [ 52.545829] [] ? cpufreq_update_policy+0x1b0/0x1b0 [ 52.615796] [] ? preempt_count_sub+0xb9/0x100 [ 52.681961] [] __cpufreq_add_dev+0x596/0x6b0 [ 52.746288] [] ? pcc_cpufreq_probe+0x4b4/0x4b4 [pcc_cpufreq] [ 52.830472] [] cpufreq_add_dev+0xe/0x10 [ 52.894106] [] subsys_interface_register+0xc1/0xf0 [ 52.970763] [] ? preempt_count_sub+0xb9/0x100 [ 53.038953] [] cpufreq_register_driver+0x117/0x2a0 [ 53.110751] [] pcc_cpufreq_init+0x55/0x9f8 [pcc_cpufreq] [ 53.186920] [] ? pcc_cpufreq_probe+0x4b4/0x4b4 [pcc_cpufreq] [ 53.267583] [] do_one_initcall+0xc8/0x1f0 [ 53.330601] [] ? __vunmap+0x9d/0x100 [ 53.388285] [] do_init_module+0x30/0x1b0 [ 53.451958] [] load_module+0x686/0x710 [ 53.514007] [] ? do_init_module+0x1b0/0x1b0 [ 53.581246] [] SyS_init_module+0x9b/0xc0 [ 53.644024] [] system_call_fastpath+0x16/0x1b