From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54349) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XXPbe-0000bh-J9 for qemu-devel@nongnu.org; Fri, 26 Sep 2014 03:06:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XXPbY-0004RZ-ET for qemu-devel@nongnu.org; Fri, 26 Sep 2014 03:06:18 -0400 Received: from mx1.redhat.com ([209.132.183.28]:9909) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XXPbY-0004R1-83 for qemu-devel@nongnu.org; Fri, 26 Sep 2014 03:06:12 -0400 Message-ID: <1411715162.865.4.camel@nilsson.home.kraxel.org> From: Gerd Hoffmann Date: Fri, 26 Sep 2014 09:06:02 +0200 In-Reply-To: <1411681094-8474-2-git-send-email-jano.vesely@gmail.com> References: <1411681094-8474-1-git-send-email-jano.vesely@gmail.com> <1411681094-8474-2-git-send-email-jano.vesely@gmail.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v4 2/3] usb-hid: Add high speed mouse configuration List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Vesely Cc: QEMU On Do, 2014-09-25 at 17:38 -0400, Jan Vesely wrote: > v2: add usb_mouse_properties > use macros for bmAttributes > v3: rebase > v4: rebase patch looks good, the only thing missing is the compat property, to make sure qemu machine types for 2.1 & older continue to have usb1 mouse+kbd by default. The property for the tablet is in hw/i386/pc_piix.c, have a look there how to do it. The compat properties for more recent machine types live in a header file (include/hw/i386/pc.h) so they can be shared between pc and q35. Oh, and the patch history should not be in the commit message. You can add the history as notes (see 'git notes'). 'git format-patch' will use three dashes to separate the notes and 'git am' will strip them off so they appear on the list message but not in the commit log. Adding the tree dashes separator to the commit message will work too, at least as long as you don't send pull requests (in which case 'git am' would have no chance to strip off the notes). cheers, Gerd