From: Eric Dumazet <eric.dumazet@gmail.com>
To: Hannes Frederic Sowa <hannes@stressinduktion.org>
Cc: "Tom Herbert" <therbert@google.com>,
"Jesper Dangaard Brouer" <brouer@redhat.com>,
"Linux Netdev List" <netdev@vger.kernel.org>,
"David S. Miller" <davem@davemloft.net>,
"Alexander Duyck" <alexander.h.duyck@intel.com>,
"Toke Høiland-Jørgensen" <toke@toke.dk>,
"Florian Westphal" <fw@strlen.de>,
"Jamal Hadi Salim" <jhs@mojatatu.com>,
"Dave Taht" <dave.taht@gmail.com>,
"John Fastabend" <john.r.fastabend@intel.com>,
"Daniel Borkmann" <dborkman@redhat.com>
Subject: Re: [PATCH net-next] dql: dql_queued() should write first to reduce bus transactions
Date: Fri, 26 Sep 2014 05:02:55 -0700 [thread overview]
Message-ID: <1411732975.16953.106.camel@edumazet-glaptop2.roam.corp.google.com> (raw)
In-Reply-To: <1411729595.1776139.172032293.6FCC3EBB@webmail.messagingengine.com>
On Fri, 2014-09-26 at 13:06 +0200, Hannes Frederic Sowa wrote:
> I thought that prefetchw() would be the canonical way to solve write
> stalls in CPUs and prepare the specific cache line to be written to.
> Interesting, thanks Eric.
True, and I have a tcp_ack() (tcp_clean_rtx_queue() more exactly) patch
that indeed uses prefetchw() to bring tcp_shinfo() in cache before the
tcp_unlink_write_queue(skb, sk);
Performance went from 570000 packets per second to 820000 packets per
second on a TSO=off GSO=off workload.
But this applies after the https://patchwork.ozlabs.org/patch/392877/
patch (tcp: change tcp_skb_pcount() location )
next prev parent reply other threads:[~2014-09-26 12:02 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-24 16:10 [net-next PATCH 0/1 V4] qdisc bulk dequeuing and utilizing delayed tailptr updates Jesper Dangaard Brouer
2014-09-24 16:12 ` [net-next PATCH 1/1 V4] qdisc: bulk dequeue support for qdiscs with TCQ_F_ONETXQUEUE Jesper Dangaard Brouer
2014-09-24 17:23 ` Eric Dumazet
2014-09-24 17:58 ` Jesper Dangaard Brouer
2014-09-24 18:34 ` Tom Herbert
2014-09-24 19:22 ` Eric Dumazet
2014-09-25 2:12 ` Eric Dumazet
2014-09-25 2:38 ` Tom Herbert
2014-09-25 2:58 ` Dave Taht
2014-09-26 18:06 ` Eric Dumazet
2014-09-25 23:40 ` Eric Dumazet
2014-09-26 6:04 ` [PATCH net-next] dql: dql_queued() should write first to reduce bus transactions Eric Dumazet
2014-09-26 8:47 ` Jesper Dangaard Brouer
2014-09-26 11:06 ` Hannes Frederic Sowa
2014-09-26 12:02 ` Eric Dumazet [this message]
2014-09-28 21:43 ` David Miller
2014-09-26 9:23 ` [net-next PATCH 1/1 V4] qdisc: bulk dequeue support for qdiscs with TCQ_F_ONETXQUEUE David Laight
2014-09-26 13:16 ` David Laight
2014-09-26 13:38 ` Eric Dumazet
2014-09-24 22:13 ` Jamal Hadi Salim
2014-09-25 8:25 ` Jesper Dangaard Brouer
2014-09-25 12:48 ` Jamal Hadi Salim
2014-09-25 14:40 ` Tom Herbert
2014-09-25 14:57 ` Jesper Dangaard Brouer
2014-09-25 15:05 ` Tom Herbert
2014-09-25 15:23 ` Jesper Dangaard Brouer
2014-09-25 15:58 ` Tom Herbert
2014-09-29 20:23 ` Jesper Dangaard Brouer
2014-09-29 20:14 ` Jesper Dangaard Brouer
2014-09-25 15:12 ` Eric Dumazet
2014-09-25 13:52 ` Dave Taht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1411732975.16953.106.camel@edumazet-glaptop2.roam.corp.google.com \
--to=eric.dumazet@gmail.com \
--cc=alexander.h.duyck@intel.com \
--cc=brouer@redhat.com \
--cc=dave.taht@gmail.com \
--cc=davem@davemloft.net \
--cc=dborkman@redhat.com \
--cc=fw@strlen.de \
--cc=hannes@stressinduktion.org \
--cc=jhs@mojatatu.com \
--cc=john.r.fastabend@intel.com \
--cc=netdev@vger.kernel.org \
--cc=therbert@google.com \
--cc=toke@toke.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.