All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2 2/2] PCI/MSI: Remove the redundant irq_set_msi_desc()
@ 2014-09-29  8:35 Yijing Wang
  0 siblings, 0 replies; only message in thread
From: Yijing Wang @ 2014-09-29  8:35 UTC (permalink / raw)
  To: bhelgaas; +Cc: linux-pci, Yijing Wang

Irq and msi_desc will be associated in arch MSI
setup code regardless of MSI or MSI-X type.
The irq_set_msi_desc() in msix_program_entries()
is redundant.

The typical MSI setup flow:
pci_enable_msix()
	msix_capability_init()
		arch_setup_msi_irqs()
			native_setup_msi_irqs()	e.g in x86
				setup_msi_irq()
					irq_set_msi_desc_off() <---

Signed-off-by: Yijing Wang <wangyijing@huawei.com>
---
 drivers/pci/msi.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/drivers/pci/msi.c b/drivers/pci/msi.c
index e0916ad..48eae97 100644
--- a/drivers/pci/msi.c
+++ b/drivers/pci/msi.c
@@ -673,7 +673,6 @@ static void msix_program_entries(struct pci_dev *dev,
 						PCI_MSIX_ENTRY_VECTOR_CTRL;
 
 		entries[i].vector = entry->irq;
-		irq_set_msi_desc(entry->irq, entry);
 		entry->masked = readl(entry->mask_base + offset);
 		msix_mask_irq(entry, 1);
 		i++;
-- 
1.7.1


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2014-09-29  8:11 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-09-29  8:35 [PATCH v2 2/2] PCI/MSI: Remove the redundant irq_set_msi_desc() Yijing Wang

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.