From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <Ian.Campbell@citrix.com>
Subject: Re: [PATCH 3/4] xen/arm: Add PSCI system_off and
 system_reset support
Date: Wed, 1 Oct 2014 15:04:07 +0100
Message-ID: <1412172247.4861.36.camel@citrix.com>
References: <1412150877-4090-1-git-send-email-suravee.suthikulpanit@amd.com>
	<1412150877-4090-4-git-send-email-suravee.suthikulpanit@amd.com>
	<alpine.DEB.2.02.1410011101570.17038@kaball.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <alpine.DEB.2.02.1410011101570.17038@kaball.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: julien.grall@linaro.org, Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On Wed, 2014-10-01 at 11:07 +0100, Stefano Stabellini wrote:
> > diff --git a/xen/arch/arm/shutdown.c b/xen/arch/arm/shutdown.c
> > index adc0529..2f63674 100644
> > --- a/xen/arch/arm/shutdown.c
> > +++ b/xen/arch/arm/shutdown.c
> > @@ -6,11 +6,6 @@
> >  #include <xen/smp.h>
> >  #include <asm/platform.h>
> >  
> > -static void raw_machine_reset(void)
> > -{
> > -    platform_reset();
> > -}
> 
> Please mention this change in the commit message.

Actually, since this is going to need a freeze exception I think it
would be good to split into individual commits which separately:
        Refactor raw_machine_reset
        (Re)Implement machine_halt
        Introduce whatever PSCI stuff is needed.

That'll make it easier to reason about and make an argument for.

BTW I'm in favour of trying to get this stuff in for 4.5.

Ian.