From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57259) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XZL99-0001uY-05 for qemu-devel@nongnu.org; Wed, 01 Oct 2014 10:44:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XZL92-0008Dl-BW for qemu-devel@nongnu.org; Wed, 01 Oct 2014 10:44:50 -0400 Received: from smtp02.citrix.com ([66.165.176.63]:16566) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XZL92-0008D9-68 for qemu-devel@nongnu.org; Wed, 01 Oct 2014 10:44:44 -0400 Message-ID: <1412174646.4861.38.camel@citrix.com> From: Ian Campbell Date: Wed, 1 Oct 2014 15:44:06 +0100 In-Reply-To: References: <1411757235-29128-1-git-send-email-dslutz@verizon.com> <1411757235-29128-2-git-send-email-dslutz@verizon.com> <5429FA0F.4050905@terremark.com> Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [Xen-devel] [PATCH 1/1] xen-hvm.c: Add support for Xen access to vmport List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefano Stabellini Cc: "xen-devel@lists.xensource.com" , Marcel Apfelbaum , Markus Armbruster , "Michael S. Tsirkin" , "qemu-devel@nongnu.org" , "Slutz, Donald Christopher" , Alexander Graf , Anthony Liguori , Andreas =?ISO-8859-1?Q?F=E4rber?= On Wed, 2014-10-01 at 10:20 +0100, Stefano Stabellini wrote: > I wonder if we could send both ioreqs at once from Xen and back from > QEMU. Or maybe append the registers to IOREQ_TYPE_VMWARE_PORT, changing > the size of ioreq_t only for this ioreq type. Random idea: Why new add a IOREQ_TYPE_FULL_STATE which would be issued for these ports and let qemu decode the fact that it is vmware internally? That might be a more generically useful interface in the future? WRT to fitting all the register state in the current sized request, you could declare that this new thing takes multiple slots. Also, I may be wrong, but I thought most IOREQs were synchronous so only one slot was ever used? The buffered ioreq stuff has a separate ring (or uses a different part of the page, or something). I might be talking nonsense here though ;-) Ian. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [Xen-devel] [PATCH 1/1] xen-hvm.c: Add support for Xen access to vmport Date: Wed, 1 Oct 2014 15:44:06 +0100 Message-ID: <1412174646.4861.38.camel@citrix.com> References: <1411757235-29128-1-git-send-email-dslutz@verizon.com> <1411757235-29128-2-git-send-email-dslutz@verizon.com> <5429FA0F.4050905@terremark.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org Sender: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org To: Stefano Stabellini Cc: "xen-devel@lists.xensource.com" , Marcel Apfelbaum , Markus Armbruster , "Michael S. Tsirkin" , "qemu-devel@nongnu.org" , "Slutz, Donald Christopher" , Alexander Graf , Anthony Liguori , Andreas =?ISO-8859-1?Q?F=E4rber?= List-Id: xen-devel@lists.xenproject.org On Wed, 2014-10-01 at 10:20 +0100, Stefano Stabellini wrote: > I wonder if we could send both ioreqs at once from Xen and back from > QEMU. Or maybe append the registers to IOREQ_TYPE_VMWARE_PORT, changing > the size of ioreq_t only for this ioreq type. Random idea: Why new add a IOREQ_TYPE_FULL_STATE which would be issued for these ports and let qemu decode the fact that it is vmware internally? That might be a more generically useful interface in the future? WRT to fitting all the register state in the current sized request, you could declare that this new thing takes multiple slots. Also, I may be wrong, but I thought most IOREQs were synchronous so only one slot was ever used? The buffered ioreq stuff has a separate ring (or uses a different part of the page, or something). I might be talking nonsense here though ;-) Ian.