All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Don't reset PHY on if_up for ASIX 88772
@ 2014-10-02  8:22 Michel Stam
  2014-10-03 22:39 ` David Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Michel Stam @ 2014-10-02  8:22 UTC (permalink / raw)
  To: netdev; +Cc: freddy, grundler, Michel Stam

I've noticed every time the interface is set to 'up,', the kernel
reports that the link speed is set to 100 Mbps/Full Duplex, even
when ethtool is used to set autonegotiation to 'off', half
duplex, 10 Mbps.
It can be tested by:
 ifconfig eth0 down
 ethtool -s eth0 autoneg off speed 10 duplex half
 ifconfig eth0 up

Then checking 'dmesg' for the link speed.

Signed-off-by: Michel Stam <m.stam@fugro.nl>
---
 drivers/net/usb/asix_devices.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/usb/asix_devices.c b/drivers/net/usb/asix_devices.c
index 5d19409..2c05f6c 100644
--- a/drivers/net/usb/asix_devices.c
+++ b/drivers/net/usb/asix_devices.c
@@ -890,7 +890,7 @@ static const struct driver_info ax88772_info = {
 	.unbind = ax88772_unbind,
 	.status = asix_status,
 	.link_reset = ax88772_link_reset,
-	.reset = ax88772_reset,
+	.reset = ax88772_link_reset,
 	.flags = FLAG_ETHER | FLAG_FRAMING_AX | FLAG_LINK_INTR | FLAG_MULTI_PACKET,
 	.rx_fixup = asix_rx_fixup_common,
 	.tx_fixup = asix_tx_fixup,
-- 
1.7.12.1

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] Don't reset PHY on if_up for ASIX 88772
  2014-10-02  8:22 [PATCH] Don't reset PHY on if_up for ASIX 88772 Michel Stam
@ 2014-10-03 22:39 ` David Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2014-10-03 22:39 UTC (permalink / raw)
  To: m.stam; +Cc: netdev, freddy, grundler

From: Michel Stam <m.stam@fugro.nl>
Date: Thu,  2 Oct 2014 10:22:02 +0200

> I've noticed every time the interface is set to 'up,', the kernel
> reports that the link speed is set to 100 Mbps/Full Duplex, even
> when ethtool is used to set autonegotiation to 'off', half
> duplex, 10 Mbps.
> It can be tested by:
>  ifconfig eth0 down
>  ethtool -s eth0 autoneg off speed 10 duplex half
>  ifconfig eth0 up
> 
> Then checking 'dmesg' for the link speed.
> 
> Signed-off-by: Michel Stam <m.stam@fugro.nl>

Applied, thank you.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-10-03 22:37 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-10-02  8:22 [PATCH] Don't reset PHY on if_up for ASIX 88772 Michel Stam
2014-10-03 22:39 ` David Miller

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.