From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 2874A1A0A6C for ; Fri, 3 Oct 2014 07:28:34 +1000 (EST) Message-ID: <1412285299.28143.33.camel@pasglop> Subject: Re: [RFC PATCH v3 1/3] powerpc: Fix warning reported by verify_cpu_node_mapping() From: Benjamin Herrenschmidt To: Nishanth Aravamudan Date: Fri, 03 Oct 2014 07:28:19 +1000 In-Reply-To: <20141002211305.GB12862@linux.vnet.ibm.com> References: <1409132041-11890-1-git-send-email-zhong@linux.vnet.ibm.com> <20141002211305.GB12862@linux.vnet.ibm.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Cc: paulus@samba.org, linuxppc-dev@lists.ozlabs.org, Nathan Fontenot , Li Zhong List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Thu, 2014-10-02 at 14:13 -0700, Nishanth Aravamudan wrote: > Ben & Michael, > > What's the status of these patches? Waiting for somebody to review them ? :-) Cheers, Ben. > Thanks, > Nish > > On 27.08.2014 [17:33:59 +0800], Li Zhong wrote: > > With commit 2fabf084b6ad ("powerpc: reorder per-cpu NUMA information's > > initialization"), during boottime, cpu_numa_callback() is called > > earlier(before their online) for each cpu, and verify_cpu_node_mapping() > > uses cpu_to_node() to check whether siblings are in the same node. > > > > It skips the checking for siblings that are not online yet. So the only > > check done here is for the bootcpu, which is online at that time. But > > the per-cpu numa_node cpu_to_node() uses hasn't been set up yet (which > > will be set up in smp_prepare_cpus()). > > > > So I saw something like following reported: > > [ 0.000000] CPU thread siblings 1/2/3 and 0 don't belong to the same > > node! > > > > As we don't actually do the checking during this early stage, so maybe > > we could directly call numa_setup_cpu() in do_init_bootmem(). > > > > Cc: Nishanth Aravamudan > > Cc: Nathan Fontenot > > Signed-off-by: Li Zhong > > --- > > arch/powerpc/mm/numa.c | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > diff --git a/arch/powerpc/mm/numa.c b/arch/powerpc/mm/numa.c > > index d7737a5..9918c02 100644 > > --- a/arch/powerpc/mm/numa.c > > +++ b/arch/powerpc/mm/numa.c > > @@ -1128,8 +1128,7 @@ void __init do_init_bootmem(void) > > * early in boot, cf. smp_prepare_cpus(). > > */ > > for_each_possible_cpu(cpu) { > > - cpu_numa_callback(&ppc64_numa_nb, CPU_UP_PREPARE, > > - (void *)(unsigned long)cpu); > > + numa_setup_cpu((unsigned long)cpu); > > } > > } > > > > -- > > 1.9.1 > >