From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH] mini-os: enable compiler check for printk format types Date: Wed, 8 Oct 2014 12:25:28 +0100 Message-ID: <1412767528.9247.5.camel@citrix.com> References: <1407318240-1799-1-git-send-email-talex5@gmail.com> <20140807145509.GK3426@type.youpi.perso.aquilenet.fr> <20140808143207.GA18842@type.bordeaux.inria.fr> <1412326515.423.11.camel@citrix.com> <20141005193018.GP5718@type> <1412602130.14255.8.camel@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1XbpN7-00050i-EU for xen-devel@lists.xenproject.org; Wed, 08 Oct 2014 11:25:33 +0000 In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Thomas Leonard Cc: Samuel Thibault , Anil Madhavapeddy , David Scott , Stefano Stabellini , "xen-devel@lists.xenproject.org" List-Id: xen-devel@lists.xenproject.org On Wed, 2014-10-08 at 12:12 +0100, Thomas Leonard wrote: > On 6 October 2014 14:28, Ian Campbell wrote: > > On Sun, 2014-10-05 at 21:30 +0200, Samuel Thibault wrote: > > > >> > Samuel, are you ok with the patch after those clarifications? > >> > >> Yes. > > > > I interpreted this as an Acked-by, I hope that's ok, and was about to > > commit when: > > disk_read.c: In function 'vtpm_load_disk': > > disk_read.c:539:59: error: format '%lu' expects argument of type 'long unsigned int', but argument 2 has type 'unsigned int' [-Werror=format] > > disk_read.c:539:59: error: format '%lu' expects argument of type 'long unsigned int', but argument 4 has type 'unsigned int' [-Werror=format] > > disk_read.c:540:2: error: format '%lu' expects argument of type 'long unsigned int', but argument 2 has type 'unsigned int' [-Werror=format] > > disk_read.c:540:2: error: format '%lu' expects argument of type 'long unsigned int', but argument 3 has type 'unsigned int' [-Werror=format] > > disk_read.c:542:30: error: format '%lu' expects argument of type 'long unsigned int', but argument 4 has type 'unsigned int' [-Werror=format] > > disk_read.c:545:47: error: format '%lu' expects argument of type 'long unsigned int', but argument 2 has type 'unsigned int' [-Werror=format] > > disk_read.c:545:47: error: format '%lu' expects argument of type 'long unsigned int', but argument 3 has type 'unsigned int' [-Werror=format] > > disk_read.c:545:47: error: format '%lu' expects argument of type 'long unsigned int', but argument 4 has type 'unsigned int' [-Werror=format] > > disk_read.c:545:47: error: format '%lu' expects argument of type 'long unsigned int', but argument 5 has type 'unsigned int' [-Werror=format] > > disk_read.c:548:21: error: format '%lu' expects argument of type 'long unsigned int', but argument 2 has type 'unsigned int' [-Werror=format] > > disk_read.c:548:21: error: format '%lu' expects argument of type 'long unsigned int', but argument 4 has type 'unsigned int' [-Werror=format] > > disk_read.c:548:21: error: format '%lu' expects argument of type 'long unsigned int', but argument 6 has type 'unsigned int' [-Werror=format] > > disk_read.c:551:21: error: format '%lu' expects argument of type 'long unsigned int', but argument 2 has type 'unsigned int' [-Werror=format] > > disk_read.c:551:21: error: format '%lu' expects argument of type 'long unsigned int', but argument 3 has type 'unsigned int' [-Werror=format] > > disk_read.c:551:21: error: format '%lu' expects argument of type 'long unsigned int', but argument 5 has type 'unsigned int' [-Werror=format] > > > > That's on an x86_32 stubdom build. > > What's the exact command I should use to test the builds? I did a > "make build" in "stubdom" in an x86_32 container and it worked*, but I > now see that doing "make" in the "stubdom/vtpmmgr" subdirectory gives > the above error. My scripts just do "make dist" in a 32-bit environment. I think make "dist XEN_TARGET_ARCH=x86_32" should be approximately the same, although I think there is some small amount stuff which isn't "cross" built. Probably dist-stubdom (or is it stubdom-dist?) would do just the bit you wanted. > * (after adding some symlinks to fix "xen-config-host.h:19:21: fatal > error: xenctrl.h: No such file or directory" error in "ioemu") As Andy says you need to update your qemu. There are some force-update targets in tools/Makefile which can help (or just nuke the trees) Ian.