From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <Ian.Campbell@citrix.com>
Subject: Re: [PATCH RFC OSSTEST 05/19] ts-host-install: Add
 fdtdir to PXE stanza if dtbs directory exists
Date: Fri, 10 Oct 2014 15:08:47 +0100
Message-ID: <1412950127.27111.26.camel@citrix.com>
References: <1412942404.27111.12.camel@citrix.com>
	<1412942554-752-5-git-send-email-ian.campbell@citrix.com>
	<21559.59059.718825.247640@mariner.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <21559.59059.718825.247640@mariner.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On Fri, 2014-10-10 at 15:01 +0100, Ian Jackson wrote:
> Ian Campbell writes ("[PATCH RFC OSSTEST 05/19] ts-host-install: Add fdtdir to PXE stanza if dtbs directory exists"):
> > u-boot's pxe client uses this together with $fdtfile in its local environment
> > to automatically load the fdt when pxe booting.
> 
> Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
> 
> Although, bikeshedding,
> 
> > +    my $dtbs = "fdtdir /$d_i/dtbs" if
> > +	-e "$ho->{Tftp}{Path}/$d_i/dtbs";
> > +
> 
> the if at the end of the line strikes me as a slightly odd style.
> There are many fewer of those in the codebase right now than places
> where it's on the start and the next line.

Yes, in fact I would naturally have done it the other way, I suppose I
wasn't paying close enough attention to my fingers...

> 
> Ian.