From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH RFC OSSTEST 11/19] standalone: Introduce "HostGroups" for use in OSSTEST_CONFIG Date: Fri, 10 Oct 2014 15:48:13 +0100 Message-ID: <1412952493.27111.40.camel@citrix.com> References: <1412942404.27111.12.camel@citrix.com> <1412942554-752-11-git-send-email-ian.campbell@citrix.com> <21559.61641.203380.196539@mariner.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <21559.61641.203380.196539@mariner.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Jackson Cc: xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On Fri, 2014-10-10 at 15:44 +0100, Ian Jackson wrote: > Ian Campbell writes ("[PATCH RFC OSSTEST 11/19] standalone: Introduce "HostGroups" for use in OSSTEST_CONFIG"): > > This saves repeating identical HostProp and HostFlags for sets of identical > > machines. e.g. > > The existing code is rather weird in that host properties from the > configuration are dealt with in TestSupport (so apply to both > standalone and executive), but host flags in the config are dealt with > in HostDB/Static.pm (so apply only to standalone). Yes, I noticed that... No reason for it, just hysterical raisins? > > I was unsure whether HostGroupProp's ought to be processed before or > > after the HostDB properties, but since the latter is a NOP I've > > arbitrarily put them before. > > The HostDB properties are not a NOP if the HostDB isn't Static! Sorry, I meant for the Static HostDB, on the basis that I don't think you would use the config file with the proper DB, would you? (which might argue for moving a bunch of code from TestSupport to HostDB/Static.pm?) > In general the configuration should override the database. So I think > this is the wrong way round. Ack. Ian.