From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH OSSTEST v2 18/20] Osstest/Debian: Add "clk_ignore_unused" to default command line Date: Thu, 30 Oct 2014 12:33:10 +0000 Message-ID: <1414672390.2064.31.camel@citrix.com> References: <1414579268.29975.13.camel@citrix.com> <1414579302-6692-18-git-send-email-ian.campbell@citrix.com> <21585.6188.366311.80971@mariner.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <21585.6188.366311.80971@mariner.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Jackson Cc: Stefano Stabellini , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org create ! title it arm: domain 0 disables clocks which are in fact being used thanks On Wed, 2014-10-29 at 16:39 +0000, Ian Jackson wrote: > Ian Campbell writes ("[PATCH OSSTEST v2 18/20] Osstest/Debian: Add "clk_ignore_unused" to default command line"): > > This stops dom0 from messing with clocks which it should and is required on > > some platforms. It's harmless even when not needed. > > This is pretty odd. Doesn't this correspond to some kind of bug, in > the dom0 kernel perhaps ? dom0 is not aware that some clocks are actually in use (e.g. by the hypervisor), so the bug is probably in the lack of some interface to communicate this from Xen to dom0, or some other mechanism to gate this. I think some or all of the above ought to be added to the commit message, and perhaps in a comment too. Along with a reference to the bug which this mail should be about to create. Would you like me to do anything else? Ian.