All of lore.kernel.org
 help / color / mirror / Atom feed
From: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
To: Gwendal Grignou <gwendal@chromium.org>
Cc: jic23@kernel.org, linux-iio@vger.kernel.org
Subject: Re: [PATCH 0/1] iio: ak8975: Add AKM0991x support.
Date: Fri, 31 Oct 2014 08:21:29 -0700	[thread overview]
Message-ID: <1414768889.3254.4.camel@spandruv-hsb-test> (raw)
In-Reply-To: <1414620097-6787-1-git-send-email-gwendal@chromium.org>

On Wed, 2014-10-29 at 15:01 -0700, Gwendal Grignou wrote:
> AK09912 is an accelerometer with the same register set as AK09911, but
> same behavior as AK8973, so I was not sure where to add the support.
> I decided to merge all AKM magnetometer support in the same file while
> being as clean as I could.
> 
AK09911 is implemented as a separate driver to have a clean. 
- Register map is different and have different indexes
- AK09911 is a very compact interface with no DRDY pin. So no support
     of interrupt or GPIO poll
- Even for polled mode no mention on ST2 register, which is required in
    ak8975 driver
- mode values are different for fuse access

I didn't get chance to check your merged driver, IMO simple standalone
driver is better if there are two many difference like above, difference
between AK09911 and AK8973.

Thanks,
Srinivas

  parent reply	other threads:[~2014-10-31 15:21 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-29 22:01 [PATCH 0/1] iio: ak8975: Add AKM0991x support Gwendal Grignou
2014-10-29 22:01 ` [PATCH] " Gwendal Grignou
2014-11-03 22:22   ` Hartmut Knaack
2014-11-04 19:41     ` [PATCHv2] " Gwendal Grignou
2014-11-05 14:31       ` Jonathan Cameron
2014-11-05 21:19         ` Gwendal Grignou
2014-11-05 22:10           ` [PATCH 0/3] Support all AKM compass in a single driver Gwendal Grignou
2014-11-05 22:10             ` [PATCH 1/3] iio: ak8975: minor fixes Gwendal Grignou
2014-11-06 15:00               ` Srinivas Pandruvada
2014-11-17 20:13               ` [PATCH v2 " Gwendal Grignou
2014-11-19 11:16                 ` Hartmut Knaack
2014-11-05 22:10             ` [PATCH 2/3] iio: ak8975: add definition structure per compass type Gwendal Grignou
2014-11-06 15:02               ` Srinivas Pandruvada
2014-11-06 21:16                 ` Gwendal Grignou
2014-11-19 11:25               ` Hartmut Knaack
2014-11-05 22:10             ` [PATCH 3/3] iio: ak8975: add ak09911 and ak09912 support Gwendal Grignou
2014-11-06 15:05               ` Srinivas Pandruvada
2014-11-06 21:25                 ` Gwendal Grignou
2014-11-17 18:02                   ` Srinivas Pandruvada
2014-11-17 20:15                     ` Gwendal Grignou
2014-11-17 20:36                       ` Srinivas Pandruvada
2014-11-19 11:39                   ` Hartmut Knaack
2014-11-08 12:16                 ` Jonathan Cameron
2014-11-14  9:01                   ` Gwendal Grignou
2014-11-06 14:32           ` [PATCHv2] iio: ak8975: Add AKM0991x support Srinivas Pandruvada
2014-11-08 12:17             ` Jonathan Cameron
2014-10-31 15:21 ` Srinivas Pandruvada [this message]
2014-11-01 21:03   ` [PATCH 0/1] " Gwendal Grignou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1414768889.3254.4.camel@spandruv-hsb-test \
    --to=srinivas.pandruvada@linux.intel.com \
    --cc=gwendal@chromium.org \
    --cc=jic23@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.