From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752516AbaKUV5n (ORCPT ); Fri, 21 Nov 2014 16:57:43 -0500 Received: from mail.linux-iscsi.org ([67.23.28.174]:50443 "EHLO linux-iscsi.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751097AbaKUV5j (ORCPT ); Fri, 21 Nov 2014 16:57:39 -0500 Message-ID: <1416607049.27880.20.camel@haakon3.risingtidesystems.com> Subject: Re: [PATCH 1/1] target: Deletion of unnecessary checks before the function call "module_put" From: "Nicholas A. Bellinger" To: SF Markus Elfring Cc: target-devel@vger.kernel.org, linux-scsi@vger.kernel.org, LKML , kernel-janitors@vger.kernel.org, Julia Lawall Date: Fri, 21 Nov 2014 13:57:29 -0800 In-Reply-To: <546F0642.4060007@users.sourceforge.net> References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <546F0642.4060007@users.sourceforge.net> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.4.4-1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2014-11-21 at 10:30 +0100, SF Markus Elfring wrote: > From: Markus Elfring > Date: Fri, 21 Nov 2014 10:25:45 +0100 > > The module_put() function tests whether its argument is NULL and then > returns immediately. Thus the test around the call is not needed. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring > --- > drivers/target/iscsi/iscsi_target_transport.c | 3 +-- > drivers/target/target_core_hba.c | 6 ++---- > 2 files changed, 3 insertions(+), 6 deletions(-) > Applied to target-pending/for-next. Thanks Markus! --nab From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Nicholas A. Bellinger" Date: Fri, 21 Nov 2014 21:57:29 +0000 Subject: Re: [PATCH 1/1] target: Deletion of unnecessary checks before the function call "module_put" Message-Id: <1416607049.27880.20.camel@haakon3.risingtidesystems.com> List-Id: References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <546F0642.4060007@users.sourceforge.net> In-Reply-To: <546F0642.4060007@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: SF Markus Elfring Cc: target-devel@vger.kernel.org, linux-scsi@vger.kernel.org, LKML , kernel-janitors@vger.kernel.org, Julia Lawall On Fri, 2014-11-21 at 10:30 +0100, SF Markus Elfring wrote: > From: Markus Elfring > Date: Fri, 21 Nov 2014 10:25:45 +0100 > > The module_put() function tests whether its argument is NULL and then > returns immediately. Thus the test around the call is not needed. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring > --- > drivers/target/iscsi/iscsi_target_transport.c | 3 +-- > drivers/target/target_core_hba.c | 6 ++---- > 2 files changed, 3 insertions(+), 6 deletions(-) > Applied to target-pending/for-next. Thanks Markus! --nab