All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: Gonglei <arei.gonglei@huawei.com>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
	"Dr. David Alan Gilbert" <dgilbert@redhat.com>
Subject: Re: [Qemu-devel] [RfC PATCH] hid: handle full ptr queues in post_load
Date: Thu, 27 Nov 2014 12:04:03 +0100	[thread overview]
Message-ID: <1417086243.3722.26.camel@nilsson.home.kraxel.org> (raw)
In-Reply-To: <5476EE1B.4090302@huawei.com>

  Hi,

> > +        evt = s->ptr.queue[(s->head+s->n) & QUEUE_MASK];
> 
> s->n is QUEUE_LENGTH, can we directly delete it?
>   evt = s->ptr.queue[s->head & QUEUE_MASK]

I prefer to make clear in the code that we want the last ring element
not the first and leave in the "+n", even if we could take it out.

cheers,
  Gerd

  reply	other threads:[~2014-11-27 11:04 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-27  9:04 [Qemu-devel] [RfC PATCH] hid: handle full ptr queues in post_load Gerd Hoffmann
2014-11-27  9:25 ` Gonglei
2014-11-27 11:04   ` Gerd Hoffmann [this message]
2014-11-27 11:16     ` Gonglei
2014-11-27 11:19       ` Gerd Hoffmann
2014-11-27 11:22         ` Gonglei
2014-11-27 12:28           ` Gonglei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1417086243.3722.26.camel@nilsson.home.kraxel.org \
    --to=kraxel@redhat.com \
    --cc=arei.gonglei@huawei.com \
    --cc=dgilbert@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.